From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590AbcFUXv7 (ORCPT ); Tue, 21 Jun 2016 19:51:59 -0400 Received: from mail-yw0-f170.google.com ([209.85.161.170]:33568 "EHLO mail-yw0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbcFUXv5 (ORCPT ); Tue, 21 Jun 2016 19:51:57 -0400 MIME-Version: 1.0 In-Reply-To: <20160621213219.GC5809@piout.net> References: <1466493519-11277-1-git-send-email-andrew.smirnov@gmail.com> <20160621213219.GC5809@piout.net> From: Andrey Smirnov Date: Tue, 21 Jun 2016 16:51:26 -0700 Message-ID: Subject: Re: [PATCH v2 00/17] DS1341 support and code cleanup To: Alexandre Belloni Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org, Chris Healy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> Andrey Smirnov (17): >> RTC: ds1307: Add DS1341 variant >> RTC: ds1307: Disable square wave and timers as default >> RTC: ds1307: Add devicetree bindings for DS1341 >> RTC: ds1307: Add DS1341 specific power-saving options >> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate >> RTC: ds1307: Convert want_irq into a predicate > > I'll have to triple check that one, it breaks in thousand different > ways, every time someone touches that code :) Wouldn't you agree that this might be an indication that the code is a bit convoluted and some cleanup is in order? ;-) > >> RTC: ds1307: Move chip configuration into a separate routine >> RTC: ds1307: Move chip sanity checking into a separate routine > > I'm not sure about the cleanup in those two patches yet, It moves a lot > of code and the readability improvement is not obvious OK, I agree that this patch moves a lot of code, and can't really argue with "not obvious" since that is subjective. Please let me know what you decide and I'll change v3 appropriately. Thanks, Andrey