From: Mina Almasry <almasrymina@google.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
broonie@kernel.org,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
Matthew Wilcox <willy@infradead.org>
Subject: Re: mmotm 2020-02-13-22-26 uploaded (mm/hugetlb.c)
Date: Fri, 14 Feb 2020 12:51:33 -0800 [thread overview]
Message-ID: <CAHS8izMhJ-2Bf+BBtXothR9nsLz9A5jJiv_tVRKUb9DwLKiN3g@mail.gmail.com> (raw)
In-Reply-To: <7ff9e944-1c6c-f7c1-d812-e12817c7a317@oracle.com>
On Fri, Feb 14, 2020 at 9:18 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> + Mina
>
> Andrew, you might want to remove those hugetlb cgroup patches from mmotm
> as they are not yet fully reviewed and have some build issues.
>
> --
> Mike Kravetz
Up to you guys but I just sent you a patch ("hugetlb: fix
CONFIG_CGROUP_HUGETLB ifdefs") that should fix this build issue.
>
> On 2/14/20 8:29 AM, Randy Dunlap wrote:
> > On 2/13/20 10:26 PM, Andrew Morton wrote:
> >> The mm-of-the-moment snapshot 2020-02-13-22-26 has been uploaded to
> >>
> >> http://www.ozlabs.org/~akpm/mmotm/
> >>
> >> mmotm-readme.txt says
> >>
> >> README for mm-of-the-moment:
> >>
> >> http://www.ozlabs.org/~akpm/mmotm/
> >>
> >> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> >> more than once a week.
> >>
> >
> > on x86_64:
> >
> > CC mm/hugetlb.o
> > In file included from ../include/linux/kernel.h:15:0,
> > from ../include/linux/list.h:9,
> > from ../mm/hugetlb.c:6:
> > ../mm/hugetlb.c: In function ‘dump_resv_map’:
> > ../mm/hugetlb.c:301:30: error: ‘struct file_region’ has no member named ‘reservation_counter’
> > rg->from, rg->to, rg->reservation_counter, rg->css);
> > ^
> > ../include/linux/printk.h:304:33: note: in definition of macro ‘pr_err’
> > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> > ^~~~~~~~~~~
> > ../mm/hugetlb.c:301:55: error: ‘struct file_region’ has no member named ‘css’
> > rg->from, rg->to, rg->reservation_counter, rg->css);
> > ^
> > ../include/linux/printk.h:304:33: note: in definition of macro ‘pr_err’
> > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> > ^~~~~~~~~~~
> > ../mm/hugetlb.c: In function ‘check_coalesce_bug’:
> > ../mm/hugetlb.c:320:10: error: ‘struct file_region’ has no member named ‘reservation_counter’
> > if (nrg->reservation_counter && nrg->from == rg->to &&
> > ^~
> > ../mm/hugetlb.c:321:10: error: ‘struct file_region’ has no member named ‘reservation_counter’
> > nrg->reservation_counter == rg->reservation_counter &&
> > ^~
> > ../mm/hugetlb.c:321:37: error: ‘struct file_region’ has no member named ‘reservation_counter’
> > nrg->reservation_counter == rg->reservation_counter &&
> > ^~
> > ../mm/hugetlb.c:322:10: error: ‘struct file_region’ has no member named ‘css’
> > nrg->css == rg->css) {
> > ^~
> > ../mm/hugetlb.c:322:21: error: ‘struct file_region’ has no member named ‘css’
> > nrg->css == rg->css) {
> > ^~
> >
> >
> > Full randconfig file is attached.
> >
next prev parent reply other threads:[~2020-02-14 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200203173311.6269a8be06a05e5a4aa08a93@linux-foundation.org>
2020-02-14 6:26 ` mmotm 2020-02-13-22-26 uploaded Andrew Morton
2020-02-14 16:29 ` mmotm 2020-02-13-22-26 uploaded (mm/hugetlb.c) Randy Dunlap
2020-02-14 17:18 ` Mike Kravetz
2020-02-14 20:51 ` Mina Almasry [this message]
[not found] ` <20200214204544.231482-1-almasrymina@google.com>
2020-02-14 21:00 ` [PATCH] hugetlb: fix CONFIG_CGROUP_HUGETLB ifdefs Mina Almasry
2020-02-15 1:17 ` Randy Dunlap
2020-02-15 1:56 ` Randy Dunlap
2020-02-16 20:40 ` Mina Almasry
2020-02-16 21:03 ` Mina Almasry
2020-02-17 2:48 ` Randy Dunlap
2020-02-17 2:57 ` [PATCH] hugetlb: fix <linux/hugetlb_cgroup.h> structs Randy Dunlap
2020-02-17 3:53 ` [PATCH] hugetlb: fix CONFIG_CGROUP_HUGETLB ifdefs Stephen Rothwell
2020-02-14 16:49 ` mmotm 2020-02-13-22-26 uploaded (mm/migrate.c, hugetlb_cgroup.h) Randy Dunlap
2020-02-25 3:53 ` mmotm 2020-02-24-19-53 uploaded Andrew Morton
2020-02-25 6:16 ` mmotm 2020-02-24-19-53 uploaded (init/main.c: initrd*) Randy Dunlap
2020-02-25 6:18 ` Randy Dunlap
2020-02-25 6:21 ` Randy Dunlap
2020-02-25 16:41 ` mmotm 2020-02-24-19-53 uploaded (drivers/platform/x86/intel_pmc_core.c) Randy Dunlap
2020-02-25 17:01 ` mmotm 2020-02-24-19-53 uploaded (objtool warning) Randy Dunlap
2020-02-27 21:52 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHS8izMhJ-2Bf+BBtXothR9nsLz9A5jJiv_tVRKUb9DwLKiN3g@mail.gmail.com \
--to=almasrymina@google.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mike.kravetz@oracle.com \
--cc=mm-commits@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).