From: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
To: Yixun Lan <yixun.lan@gmail.com>
Cc: Maxime Jourdan <maxi.jourdan@wanadoo.fr>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic <linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH 1/4] soc: amlogic: add meson-canvas driver
Date: Fri, 3 Aug 2018 23:47:51 +0200 [thread overview]
Message-ID: <CAHStOZ5W+jJRox3=Nnem+Z1zopFOUenpmT-QkUzd5hrmKXfX5A@mail.gmail.com> (raw)
In-Reply-To: <CALecT5i1mnkvi4WuL701cA+UnRL9CKmj=CMqLEWN=fpbxfi7ZQ@mail.gmail.com>
Hi Yixun, thanks for the review
2018-08-03 16:14 GMT+02:00 Yixun Lan <yixun.lan@gmail.com>:
>> +config MESON_CANVAS
>> + bool "Amlogic Meson Canvas driver"
> shouldn't this a 'tristate'? since you'd make the driver a kernel module..
Yep it should!
I well noted your other feedback and v2 will have fixes for them :) .
next prev parent reply other threads:[~2018-08-03 21:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 18:51 [PATCH 0/4] soc: amlogic: add meson-canvas driver Maxime Jourdan
2018-08-01 18:51 ` [PATCH 1/4] " Maxime Jourdan
2018-08-02 8:38 ` Neil Armstrong
2018-08-02 8:52 ` Neil Armstrong
2018-08-02 13:14 ` Maxime Jourdan
2018-08-03 14:14 ` Yixun Lan
2018-08-03 21:47 ` Maxime Jourdan [this message]
2018-08-01 18:51 ` [PATCH 2/4] dt-bindings: soc: amlogic: add meson-canvas documentation Maxime Jourdan
2018-08-01 18:51 ` [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes Maxime Jourdan
2018-08-03 13:50 ` Yixun Lan
2018-08-04 20:02 ` Maxime Jourdan
2018-08-07 1:29 ` Yixun Lan
2018-08-01 18:51 ` [PATCH 4/4] drm/meson: convert to the new canvas module Maxime Jourdan
2018-08-02 8:39 ` Jerome Brunet
2018-08-02 12:34 ` Maxime Jourdan
2018-08-02 13:01 ` Jerome Brunet
2018-08-02 13:09 ` Maxime Jourdan
[not found] ` <5b6cc316.1c69fb81.682d3.1216@mx.google.com>
2018-08-10 6:35 ` Maxime Jourdan
2018-08-10 7:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHStOZ5W+jJRox3=Nnem+Z1zopFOUenpmT-QkUzd5hrmKXfX5A@mail.gmail.com' \
--to=maxi.jourdan@wanadoo.fr \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=yixun.lan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).