linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Michal Kubecek <mkubecek@suse.cz>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] parport: daisy: do not try to load lowlevel driver
Date: Mon, 25 Mar 2019 14:48:50 -0700	[thread overview]
Message-ID: <CAHk-=wg+3Hrg=2BLd0kVN6FjDCB6K1sMY0pYBxq3gFzdiYUe1w@mail.gmail.com> (raw)
In-Reply-To: <20190325211325.21411-1-sudipm.mukherjee@gmail.com>

On Mon, Mar 25, 2019 at 2:13 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> We do not need to search for ports and bind the initial list of ports
> to daisy driver as daisy driver is always the first driver to use the
> new found parport and we know when the parport bus is registering the
> list of parport will always be empty. So, proceed with the daisy_drv
> registration even if the list of parport is empty.

This is completely hacky and senseless.

The problem as far as I can tell is that the daisy driver shouldn't
register early at all, and shouldn't be a subsys initcall. It should
just be a driver initcall, and happen naturally after the parport
subsystem has been initialized.

This patch just makes the code even *less* understandable.

I'm going to revert that problematic commit.

If you can get it working without that incorrect and senseless tie-in
of the daisy driver registration with the regular partport init
sequence, we can revisit this.

                      Linus

  reply	other threads:[~2019-03-25 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 21:13 [PATCH] parport: daisy: do not try to load lowlevel driver Sudip Mukherjee
2019-03-25 21:48 ` Linus Torvalds [this message]
2019-03-25 22:34   ` Sudip Mukherjee
2019-03-25 21:53 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wg+3Hrg=2BLd0kVN6FjDCB6K1sMY0pYBxq3gFzdiYUe1w@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=rostedt@goodmis.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).