From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70330C433EF for ; Wed, 1 Jun 2022 20:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbiFAUty (ORCPT ); Wed, 1 Jun 2022 16:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbiFAUsj (ORCPT ); Wed, 1 Jun 2022 16:48:39 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 537D028184F for ; Wed, 1 Jun 2022 13:45:37 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id z13so3240357ljn.11 for ; Wed, 01 Jun 2022 13:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e5mcrmCWuAAdbPHfrDc3j0Y3Y9fXO5pJ7wBIk1OP74A=; b=X7Tv7jSyurwqAxOftMCv8MB8L2erC6H7qza7nZau5SMv9NuJDXz++xqv2TCO8O1eNZ fqueWV6byN8z2Gu+uMcXfpESO4zCepIeF9lE38C7p3G9ruL4ZOJc2FAVWNdk/Nm5vop/ sQfYhypjYychJXBmewMMJChgZZn1Gv4yaRaNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e5mcrmCWuAAdbPHfrDc3j0Y3Y9fXO5pJ7wBIk1OP74A=; b=txjcgQY8RW56owL5YLyqxAXzWx/IZ3l/CXXhUYC02kbQCsWvVtqPNETR5BARgWgW+q rc9r4iF2/herF1hpBRj2kpTj0Hg0ZrBUQY1nUObNM9tDrRLLY4O9h2w3kCQvoHukmRnB jDr5Bm6FtYE4Jcbu7EEDcuPY8ZCBY546C3D43w/qV19QhYvRnrJWLrartXiOKArL5QOx ziBqs6IHL29gbb5tyO6VBdVW32GMY4n1GWueW/n9thXKLAY46eKcYq8JxcxmpTxgk4MY Ci9ZWjghvGZIoCzW3sk1YcpcYy7xPjGQ7dDNvfzPAfJ2tC9UpXSWV6Sc1Y2Hkh5voJGp bp+Q== X-Gm-Message-State: AOAM530JVWl40pI8q/F4U+pracwQHxpxGNDKUJs6iQoOHpEH62tJu1Hl Wy1htuTwdjJXym2gnbqP2WODWe7gxS4B/G7D X-Google-Smtp-Source: ABdhPJziyyQKVnx0Tzrcrjkiumw8JZWyDUphU5Are/EY+JBtPJMkdRvEsDCKVeIPOjW5DPEYfFwwMw== X-Received: by 2002:a05:6402:d9:b0:42a:c890:20b5 with SMTP id i25-20020a05640200d900b0042ac89020b5mr1403712edu.101.1654111936038; Wed, 01 Jun 2022 12:32:16 -0700 (PDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id og10-20020a1709071dca00b006f3ef214df5sm1011545ejc.91.2022.06.01.12.32.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 12:32:14 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id r9-20020a1c4409000000b00397345f2c6fso3607486wma.4 for ; Wed, 01 Jun 2022 12:32:14 -0700 (PDT) X-Received: by 2002:a1c:7207:0:b0:397:66ee:9d71 with SMTP id n7-20020a1c7207000000b0039766ee9d71mr872637wmc.8.1654111934219; Wed, 01 Jun 2022 12:32:14 -0700 (PDT) MIME-Version: 1.0 References: <5ec6759ab3b617f9c12449a9606b6f0b5a7582d0.1654086665.git.legion@kernel.org> In-Reply-To: From: Linus Torvalds Date: Wed, 1 Jun 2022 12:31:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/4] sysctl: API extension for handling sysctl To: Matthew Wilcox Cc: Alexey Gladkov , LKML , "Eric W . Biederman" , Andrew Morton , Christian Brauner , Iurii Zaikin , Kees Cook , Linux Containers , linux-fsdevel , Luis Chamberlain , Vasily Averin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 1, 2022 at 12:25 PM Matthew Wilcox wrote: > > I wasn't suggesting the iovec. Just the iocb, instead of passing in the > ki_filp and the ki_pos. I guess that would work, but would it actually help anything? I think it's a lot more obvious when it just looks mostly like a "read/write()" system call (ok, pread/pwrite since you get the pos, but still). There is nothing that could possibly be relevant in the kiocb. All those fields are about odd async or atomicity issues (or "report completion" issues) that simply cannot possibly be valid for a sysctl value. And if they are, that sysctl value is doing something really really really wrong. So we absolutely don't want to encourage that. This is not a "do IO" interface. This is a "read or write value" interface. Linus