From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>,
mgorman@techsingularity.net, Michal Hocko <mhocko@kernel.org>,
ying.huang@intel.com, s.priebe@profihost.ag,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
alex.williamson@redhat.com, lkp@01.org, kirill@shutemov.name,
Andrew Morton <akpm@linux-foundation.org>,
zi.yan@cs.rutgers.edu
Subject: Re: [patch for-4.20] Revert "mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask"
Date: Fri, 7 Dec 2018 14:33:40 -0800 [thread overview]
Message-ID: <CAHk-=wiGjzXQSPhq-TNkwUAqZKNobOgyJJKMXFooaOMyDDG38g@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1812071421030.148470@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Fri, Dec 7, 2018 at 2:27 PM David Rientjes <rientjes@google.com> wrote:
>
> I noticed the race in 89c83fb539f9 ("mm, thp: consolidate THP gfp handling
> into alloc_hugepage_direct_gfpmask") that is fixed by the revert, but as
> you noted it didn't cleanup the second part which is the balancing act for
> gfp flags between alloc_hugepage_direct_gfpmask() and alloc_pages_vma().
> Syzbot found this to trigger the WARN_ON_ONCE() you mention.
Can you rewrite the commit message to explain this better rather than
the misleading "race" description?
Linus
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5120 bytes --]
prev parent reply other threads:[~2018-12-07 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 22:46 [patch v2 for-4.20] mm, thp: restore node-local hugepage allocations David Rientjes
2018-12-06 4:59 ` [LKP] " kernel test robot
2018-12-06 21:42 ` David Rientjes
2018-12-06 22:00 ` [patch for-4.20] Revert "mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask" David Rientjes
2018-12-07 8:05 ` Michal Hocko
2018-12-07 23:05 ` David Rientjes
2018-12-10 8:34 ` Michal Hocko
2018-12-10 13:28 ` Kirill A. Shutemov
2018-12-07 14:41 ` Vlastimil Babka
2018-12-07 22:27 ` David Rientjes
2018-12-07 22:33 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiGjzXQSPhq-TNkwUAqZKNobOgyJJKMXFooaOMyDDG38g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=s.priebe@profihost.ag \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).