From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>, Nick Hu <nickhu@andestech.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
"David S . Miller" <davem@davemloft.net>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michal Simek <monstr@monstr.eu>, Borislav Petkov <bp@alien8.de>,
Guo Ren <guoren@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Joshua Kinard <kumba@gentoo.org>,
David Laight <David.Laight@aculab.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Eric Biggers <ebiggers@google.com>,
Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
Lennart Poettering <mzxreary@0pointer.de>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH v1] random: block in /dev/urandom
Date: Tue, 22 Mar 2022 11:29:21 -0700 [thread overview]
Message-ID: <CAHk-=wiq3bKDdt7noWOaMnDL-yYfFHb1CEsNkk8huq4O7ByetA@mail.gmail.com> (raw)
In-Reply-To: <YjoTJFRook+rGyDI@zx2c4.com>
On Tue, Mar 22, 2022 at 11:19 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> The first point is why we had to revert this patch. But the second one
> is actually a bit dangerous: you might write in a perfectly good seed to
> /dev/urandom, but what you read out for the subsequent seed may be
> complete deterministic crap. This is because the call to write_pool()
> goes right into the input pool and doesn't touch any of the "fast init"
> stuff, where we immediately mutate the crng key during early boot.
Christ, how I hate the crazy "no entropy means that we can't use it".
It's a disease, I tell you.
And it seems to be the direct cause of this misfeature.
By all means the code can say "I can't credit this as entropy", but
the fact that it then doesn't even mix it into the fast pool is just
wrong, wrong, wrong.
I think *that* is what we should fix. The fact is, urandom has
long-standing semantics as "don't block", and that it shouldn't care
about the (often completely insane) entropy crediting rules.
But that "don't care about entropy rules" should then also mean "oh,
we'll mix things in even if we don't credit entropy".
I hope that's the easy fix you are thinking about.
Linus
next prev parent reply other threads:[~2022-03-22 18:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 16:28 [PATCH v1] random: block in /dev/urandom Jason A. Donenfeld
2022-02-21 18:01 ` Andy Lutomirski
2022-02-23 17:02 ` Jason A. Donenfeld
2022-02-23 17:55 ` Theodore Ts'o
2022-03-12 20:17 ` Eric Biggers
2022-03-12 20:27 ` Eric Biggers
2022-03-22 15:58 ` Guenter Roeck
2022-03-22 16:21 ` Linus Torvalds
2022-03-22 16:40 ` Jason A. Donenfeld
2022-03-22 17:09 ` Jason A. Donenfeld
2022-03-22 17:56 ` Guenter Roeck
2022-03-22 18:19 ` Jason A. Donenfeld
2022-03-22 18:29 ` Linus Torvalds [this message]
2022-03-22 18:36 ` Jason A. Donenfeld
2022-04-22 13:42 ` Jason A. Donenfeld
2022-04-22 23:46 ` Guenter Roeck
2022-04-23 13:56 ` Guenter Roeck
2022-04-23 14:28 ` Jason A. Donenfeld
2022-04-23 16:35 ` Guenter Roeck
2022-04-23 21:10 ` Jason A. Donenfeld
2022-04-24 2:04 ` Guenter Roeck
2022-04-25 0:12 ` Jason A. Donenfeld
2022-04-25 1:54 ` Guenter Roeck
2022-04-25 11:11 ` Jason A. Donenfeld
2022-03-22 18:24 ` Mark Brown
2022-03-22 21:54 ` Guenter Roeck
2022-03-22 22:25 ` David Laight
2022-03-23 12:10 ` Mark Brown
2022-03-23 14:23 ` Guenter Roeck
2022-03-23 15:53 ` Arnd Bergmann
2022-03-23 16:18 ` Mark Brown
2022-03-23 16:41 ` Arnd Bergmann
2022-03-23 16:47 ` Mark Brown
2022-04-23 0:52 ` Jason A. Donenfeld
2022-04-25 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiq3bKDdt7noWOaMnDL-yYfFHb1CEsNkk8huq4O7ByetA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=David.Laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=ebiggers@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=keescook@chromium.org \
--cc=konstantin@linuxfoundation.org \
--cc=kumba@gentoo.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@roeck-us.net \
--cc=luto@kernel.org \
--cc=monstr@monstr.eu \
--cc=mzxreary@0pointer.de \
--cc=nickhu@andestech.com \
--cc=palmer@dabbelt.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).