From: Linus Torvalds <torvalds@linux-foundation.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Michal Hocko <mhocko@suse.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>,
Waiman Long <longman@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Chris Down <chris@chrisdown.name>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Tejun Heo <tj@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Yafang Shao <laoar.shao@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, kernel test robot <lkp@intel.com>,
zhengjun.xing@intel.com, "Huang, Ying" <ying.huang@intel.com>,
andi.kleen@intel.com
Subject: Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression
Date: Thu, 26 Nov 2020 09:39:23 -0800 [thread overview]
Message-ID: <CAHk-=wjvQzJts-5PnFnJcUU5M3ZFv6RSaS01Mchv0unPzh-XVA@mail.gmail.com> (raw)
In-Reply-To: <20201125062445.GA51005@shbuild999.sh.intel.com>
On Tue, Nov 24, 2020 at 10:24 PM Feng Tang <feng.tang@intel.com> wrote:
>
> And with the following patch to relayout these members, the regression
> is restored and event better. while reducing 64 bytes of sizeof
> 'struct mem_cgroup'
Thanks, applied.
I do wonder if somebody on the hardware side inside Intel might not
perhaps want to look at that load pattern and at why performance
regressed so much. Maybe teach the prefetcher to avoid adjacent cache
lines that end up showing ping-pong behavior..
Linus
next prev parent reply other threads:[~2020-11-26 17:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 9:15 [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression kernel test robot
2020-11-02 9:27 ` Michal Hocko
2020-11-02 9:53 ` [LKP] " Rong Chen
2020-11-02 10:02 ` Michal Hocko
2020-11-04 1:20 ` Xing Zhengjun
2020-11-04 2:46 ` Waiman Long
2020-11-04 8:15 ` Michal Hocko
2020-11-12 12:28 ` Feng Tang
2020-11-12 14:16 ` Michal Hocko
2020-11-12 16:43 ` Waiman Long
2020-11-13 7:39 ` Feng Tang
2020-11-13 7:34 ` Feng Tang
2020-11-20 11:44 ` Feng Tang
2020-11-20 13:19 ` Michal Hocko
2020-11-20 14:30 ` Feng Tang
2020-11-25 6:24 ` Feng Tang
2020-11-26 1:34 ` Waiman Long
2020-11-26 17:39 ` Linus Torvalds [this message]
2020-11-30 8:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjvQzJts-5PnFnJcUU5M3ZFv6RSaS01Mchv0unPzh-XVA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=chris@chrisdown.name \
--cc=feng.tang@intel.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=ying.huang@intel.com \
--cc=zhengjun.xing@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).