From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC53C433EF for ; Wed, 9 Feb 2022 10:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbiBIKnA (ORCPT ); Wed, 9 Feb 2022 05:43:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiBIKmx (ORCPT ); Wed, 9 Feb 2022 05:42:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347EAE09EA5C; Wed, 9 Feb 2022 02:28:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 63497B81878; Wed, 9 Feb 2022 10:28:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E24C2C340E7; Wed, 9 Feb 2022 10:27:59 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="K4XKSBwt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1644402478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3NnMzVYILfu4qmxKBnwiknhBgeg952L7E+Eso3InzA=; b=K4XKSBwtgS5Zc+l/F1X6ytfrRQi4Rm9kMu2unN4SZ9HRzsdNON5tfVU1T6YC5OyiFHtpec Pv6232JC+okTYNsY+/PQjVGgSsmwH/YkvjF6zruey3aiOBK5pWQBBJFPyoqqA3TBjHLZZ9 OubW7uLvMC4bj5D+BhMtKkPei2tftpg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 83310290 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 9 Feb 2022 10:27:58 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id m6so4466875ybc.9; Wed, 09 Feb 2022 02:27:58 -0800 (PST) X-Gm-Message-State: AOAM531bx6nG4slIEGHCU3/whwDg7lSvlwxs1azEiEvC9n92yXz7DSB/ 755ej+RVbdINtYmLN57HBv+rSUmRsHVX7U1gKoE= X-Google-Smtp-Source: ABdhPJy6leqE3RrEOZ6Ff6kOA1CA9LjcupmA3FH/19S9uFOcOfyI/JUGPBKMalPf0oHEcxZfhk3ZbnPVge06OLGwiH4= X-Received: by 2002:a25:c006:: with SMTP id c6mr1325215ybf.457.1644402477501; Wed, 09 Feb 2022 02:27:57 -0800 (PST) MIME-Version: 1.0 References: <20220209011919.493762-1-Jason@zx2c4.com> <20220209011919.493762-4-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 9 Feb 2022 11:27:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/9] random: inline leaves of rand_initialize() To: Dominik Brodowski Cc: Linux Crypto Mailing List , LKML , "Theodore Ts'o" , Eric Biggers , Eric Biggers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 9, 2022 at 9:31 AM Dominik Brodowski wrote: > > Am Wed, Feb 09, 2022 at 02:19:13AM +0100 schrieb Jason A. Donenfeld: > > This is a preparatory commit for the following one. We simply inline the > > various functions that rand_initialize() calls that have no other > > callers. The compiler was doing this anyway before. Doing this will > > allow us to reorganize this after. > > You also move some other code around (parse_trust_cpu() etc.), so please > mention that in the commit message or leave these parts where they are. > Other than that, feel free to add my Will do.