From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@google.com>
Cc: "David Miller" <davem@davemloft.net>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Martin Willi" <martin@strongswan.org>,
"WireGuard mailing list" <wireguard@lists.zx2c4.com>,
"René van Dorst" <opensource@vdorst.com>
Subject: Re: [PATCH] poly1305: generic C can be faster on chips with slow unaligned access
Date: Mon, 7 Nov 2016 20:02:35 +0100 [thread overview]
Message-ID: <CAHmME9rzBST8Lqapzykwf2rUyxLXuyOF0wX+Sy259Qtx9a4YSg@mail.gmail.com> (raw)
In-Reply-To: <20161107182646.GA34388@google.com>
On Mon, Nov 7, 2016 at 7:26 PM, Eric Biggers <ebiggers@google.com> wrote:
>
> I was not referring to any users in particular, only what users could do. As an
> example, if you did crypto_shash_update() with 32, 15, then 17 bytes, and the
> underlying algorithm is poly1305-generic, the last block would end up
> misaligned. This doesn't appear possible with your pseudocode because it only
> passes in multiples of the block size until the very end. However I don't see
> it claimed anywhere that shash API users have to do that.
Actually it appears that crypto/poly1305_generic.c already buffers
incoming blocks to a buffer that definitely looks aligned, to prevent
this condition!
I'll submit a v2 with only the inner unaligned operations changed.
next prev parent reply other threads:[~2016-11-07 19:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 17:58 [PATCH] poly1305: generic C can be faster on chips with slow unaligned access Jason A. Donenfeld
2016-11-02 20:09 ` Herbert Xu
2016-11-02 20:47 ` Sandy Harris
2016-11-02 21:06 ` Jason A. Donenfeld
2016-11-02 21:08 ` Herbert Xu
2016-11-02 21:25 ` Jason A. Donenfeld
2016-11-02 21:26 ` Herbert Xu
2016-11-02 22:00 ` Jason A. Donenfeld
2016-11-03 0:49 ` Herbert Xu
2016-11-03 7:24 ` Jason A. Donenfeld
2016-11-03 17:08 ` David Miller
2016-11-03 22:20 ` Jason A. Donenfeld
2016-11-04 17:37 ` Eric Biggers
2016-11-07 18:08 ` Jason A. Donenfeld
2016-11-07 18:23 ` Jason A. Donenfeld
2016-11-07 18:26 ` Eric Biggers
2016-11-07 19:02 ` Jason A. Donenfeld [this message]
2016-11-07 19:25 ` Eric Biggers
2016-11-07 19:41 ` Jason A. Donenfeld
2016-11-07 19:12 ` [PATCH v2] " Jason A. Donenfeld
2016-11-07 19:43 ` [PATCH v3] " Jason A. Donenfeld
2016-11-12 23:27 ` kbuild test robot
2016-11-07 19:47 ` [PATCH v4] " Jason A. Donenfeld
2016-11-07 20:40 ` Eric Biggers
2016-11-08 7:52 ` Martin Willi
2016-11-08 17:26 ` Eric Biggers
2016-11-13 11:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rzBST8Lqapzykwf2rUyxLXuyOF0wX+Sy259Qtx9a4YSg@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@strongswan.org \
--cc=opensource@vdorst.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).