Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
	<linux-rtc@vger.kernel.org>,
	"Ludovic Desroches" <Ludovic.Desroches@microchip.com>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Alexandru Ardelean" <aardelean@deviqon.com>,
	linux-pwm@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Mark Brown" <broonie@kernel.org>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Claudiu Beznea" <Claudiu.Beznea@microchip.com>
Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]
Date: Mon, 2 Aug 2021 20:13:05 +0300	[thread overview]
Message-ID: <CAHp75VcpA0vOwN8gBj2iikXW2dw+KCgZEM=QJ5Jx6UWqww=iCw@mail.gmail.com> (raw)
In-Reply-To: <20210802163824.GK22278@shell.armlinux.org.uk>

On Mon, Aug 2, 2021 at 7:38 PM Russell King (Oracle)
<linux@armlinux.org.uk> wrote:
> On Mon, Aug 02, 2021 at 05:27:55PM +0200, Uwe Kleine-König wrote:
> > Hello Russell,
> > On Mon, Aug 02, 2021 at 10:48:10AM +0100, Russell King (Oracle) wrote:

...

> > > There have been several different approaches to wrapping things up,
> > > but here's a question: should we make it easier to do the lazy thing
> > > (get+enable) or should we make it easier to be power efficient?
> > > Shouldn't we be encouraging people to write power efficient drivers?
> >
> > Yeah, sounds compelling, but I wonder if that's of practical importance.
> > How many driver authors do you expect to lure into making a better
> > driver just because devm_clk_get_prepared() doesn't exist? In contrast:
> > How many drivers become simpler with devm_clk_get_prepared() and so
> > it becomes easier to maintain them and easier to spot bugs?
> > In the absence of devm_clk_get_prepared(), is it better that several
> > frameworks (or drivers) open code it?
>
> It probably depends on where you stand on power management and power
> efficiency issues. Personally, I would like to see more effort put
> into drivers to make them more power efficient, and I believe in the
> coming years, power efficiency is going to become a big issue.

While in the ideal world I 100% agree with the approach, IRL we have
to deal with constantly degrading quality of the code and instead of
thinking about power management and efficiency the absence of APIs
such as discussed provokes not only creating the power management
inefficient code, but also memory leaks here and there.

-- 
With Best Regards,
Andy Shevchenko