From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D65C433E7 for ; Sun, 18 Oct 2020 18:33:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79C3322261 for ; Sun, 18 Oct 2020 18:33:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VB2Ag15G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727393AbgJRSdZ (ORCPT ); Sun, 18 Oct 2020 14:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbgJRSdY (ORCPT ); Sun, 18 Oct 2020 14:33:24 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59F69C061755; Sun, 18 Oct 2020 11:33:24 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id t4so1225053plq.13; Sun, 18 Oct 2020 11:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0SrAGDyFK2BtNvaUQ65CcmVzLfIt/f5Hvduu3nRwUdw=; b=VB2Ag15GmAzpJXuXh/iym02MciTot9l2fl+pc6XM5bOK7OPRdiykb7AKYo9fIUnRP7 hOWMciGEd1qdenktWa0UyCr0Kv/wSy6LjWPGLt+a+F5xN9pI8MXwvUhXasGbLmmJzExL cMFPu0rd/1lehBji8g7bez6LDDQ8lNS4Dlumq7aUwdkhpsIB137fEoTbYR0uThA/IclT EvWIMYTXSyoVVR8zDfrj0C2g3SsWj0imX5MF0nbeXA/z2XsEcg8PF2Zofp2kK332ljDp 5K3w/TntEfYGYI0PfLG4/HPNCSE7wDQSdeLNzOVfTmBs1FyL7nj8QcdHRYCWprALypao Vpyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0SrAGDyFK2BtNvaUQ65CcmVzLfIt/f5Hvduu3nRwUdw=; b=SLWxDGy6O+8e6oqkYeDboT/YfEiIvVqbmUf3l1xYp6RUA6LuNjpMpoGK6+RGYMQI3j lOU0WfQ4AvcdwIoktDo+zYIWQyxFJAAHMjKWRCL4+YBbCzX494nyWpdIwXxDS/c0KvBS vfSs1Jdk7/AVSg2CIxgD2bqQIyk3DXJiIf55xxFQZqdMo22GgbyDTo6ATFvIDvoPYED7 Pm89BAklBYFaMR2iqhuewmLxuXI+rgy6oU20oTutJY5G2DTwHux4udGX7069UXarH/im iICPzo8o4vbxeKxhsW3g87wAN1UKHlHxsMz7yfXLjSA0mErKqdP/n+YJHYQKqlbZbVuY 8icg== X-Gm-Message-State: AOAM5338GLrxk/ljCr4ytMSHDsbnRkWzqQPZTT6YRZp+e9cZVHU8Axzj 4Bvh9gf747fqkogPh9MIjgoCZhif2bSuTJMd5kw= X-Google-Smtp-Source: ABdhPJypeDUZ9reAGTE+LRn4S1EdN7M3XMYdbpqrqhgMlq3vVZ/xmPqYOcYlt663OzGWlvWpihVjCdE36fP7laIhiLA= X-Received: by 2002:a17:90a:be11:: with SMTP id a17mr13500911pjs.181.1603046003874; Sun, 18 Oct 2020 11:33:23 -0700 (PDT) MIME-Version: 1.0 References: <20201018171545.3190476-1-fparent@baylibre.com> In-Reply-To: From: Andy Shevchenko Date: Sun, 18 Oct 2020 21:33:08 +0300 Message-ID: Subject: Re: [PATCH v2] iio: adc: mediatek: fix unset field To: Fabien Parent Cc: Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List , linux-iio , Matthias Brugger , Jonathan Cameron , chun-hung.wu@mediatek.com, Alexandru Ardelean , Peter Meerwald , Lars-Peter Clausen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko wrote: > > On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent wrote: > > > > dev_comp field is used in a couple of places but it is never set. This > > results in kernel oops when dereferencing a NULL pointer. Set the > > `dev_comp` field correctly in the probe function. > > > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support") > > > > Signed-off-by: Fabien Parent > > Shouldn't be a blank line in the tag block. > > I think Jonathan can fix it, but be more careful in the future. One more serious issue, you forgot to add tags you have gotten in the previous round. -- With Best Regards, Andy Shevchenko