From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"John Thomson" <git@johnthomson.fastmail.com.au>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
NeilBrown <neil@brown.name>,
"René van Dorst" <opensource@vdorst.com>,
"Nicholas Mc Guire" <hofrat@osadl.org>
Subject: Re: [PATCH v2] gpio: mt7621: support gpio-line-names property
Date: Fri, 2 Jul 2021 12:56:10 +0300 [thread overview]
Message-ID: <CAHp75Vdr9iM0a4EA3pKE5W=jHeeGk_u_5ygXE81L5mWtGhYHTw@mail.gmail.com> (raw)
In-Reply-To: <CAMhs-H_Ne4W79Awbmo6w_68X+h0-ybjvzNsbh=XuHMPJJ8-hDQ@mail.gmail.com>
On Fri, Jul 2, 2021 at 12:40 PM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
> On Fri, Jul 2, 2021 at 11:27 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sun, Jun 27, 2021 at 4:13 PM Sergio Paracuellos
> > <sergio.paracuellos@gmail.com> wrote:
> > > On Sun, Jun 27, 2021 at 3:01 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
> > > > On Sun, Jun 27, 2021 at 1:56 PM Sergio Paracuellos
> > > > <sergio.paracuellos@gmail.com> wrote:
...
> > > > Can you point out the DT in question?
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/mt7621-dts/mt7621.dtsi?h=staging-next
> > >
> > > Gpio node:
> > >
> > > gpio: gpio@600 {
> > > #gpio-cells = <2>;
> > > #interrupt-cells = <2>;
> > > compatible = "mediatek,mt7621-gpio";
> > > gpio-controller;
> > > gpio-ranges = <&pinctrl 0 0 95>;
> > > interrupt-controller;
> > > reg = <0x600 0x100>;
> > > interrupt-parent = <&gic>;
> > > interrupts = <GIC_SHARED 12 IRQ_TYPE_LEVEL_HIGH>;
> > > };
> > >
> > > My overlay:
> > >
> > > &gpio {
> > > gpio-line-names = "", "", "", "",
> > > "", "", "SFP LOS", "extcon port5 PoE compat",
> > > "SFP module def0", "LED blue SFP", "SFP tx disable", "",
> > > "switch USB power", "mode", "", "buzzer",
> > > "LED blue pwr", "switch port5 PoE out", "reset";
> > > };
> > >
> > > > > This commit populates the gc.names member of each bank from the
> > > > > device-tree node within the driver. This overrides the default behavior
> > > > > since devprop_gpiochip_set_names() will only be called if names is NULL.
> > > >
> > > > I believe this commit is not needed in the proposed (i.e. duplication) shape.
> > > > The fwnode supports primary and secondary ones. Thus, we may create a
> > > > pair of fwnodes when they will unify properties per device with
> > > > properties per child together (child is primary and device, i.e.
> > > > parent, is secondary).
> > >
> > > There are no child nodes, all the stuff is in the same parent node
> > > and, as I said, belongs to the same device but internally uses three
> > > gpiochips.
> >
> > And it can't be split into three children in the overlay?
>
> Original code before this being mainlined was using three children and
> I was told in the review that three children were not allowed:
>
> See https://patchwork.ozlabs.org/project/linux-gpio/patch/1527924610-13135-3-git-send-email-sergio.paracuellos@gmail.com/#1932827
Thanks for the pointer!
> > Let's assume it can't, then the GPIO library function should be
> > refactored in a way that it takes parameters like base index for the
> > names and tries to satisfy the caller.
>
> Bartosz, Linus, any thoughts on this?
Reading that discussion and seeing Linus there, I guess he himself
signed (implicitly) for my idea :-)
Otherwise we will have duplication of the code for almost no benefit
when we can avoid it completely.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-02 9:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:18 [PATCH v2] gpio: mt7621: support gpio-line-names property Sergio Paracuellos
2021-06-27 9:33 ` Andy Shevchenko
2021-06-27 9:47 ` Sergio Paracuellos
2021-06-27 10:51 ` Andy Shevchenko
2021-06-27 10:56 ` Sergio Paracuellos
2021-06-27 13:00 ` Andy Shevchenko
2021-06-27 13:12 ` Sergio Paracuellos
2021-07-02 9:26 ` Andy Shevchenko
2021-07-02 9:40 ` Sergio Paracuellos
2021-07-02 9:56 ` Andy Shevchenko [this message]
2021-07-02 10:18 ` Linus Walleij
2021-07-02 11:30 ` Sergio Paracuellos
2021-07-03 11:06 ` Sergio Paracuellos
2021-07-03 11:32 ` Andy Shevchenko
2021-07-03 12:05 ` Sergio Paracuellos
2021-07-03 12:51 ` Sergio Paracuellos
2021-07-03 19:36 ` Andy Shevchenko
2021-07-04 5:57 ` Sergio Paracuellos
2021-07-04 8:06 ` Sergio Paracuellos
2021-07-04 10:04 ` Andy Shevchenko
2021-07-04 11:25 ` Sergio Paracuellos
2021-07-04 11:35 ` Andy Shevchenko
2021-07-04 20:07 ` Sergio Paracuellos
2021-07-04 20:15 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdr9iM0a4EA3pKE5W=jHeeGk_u_5ygXE81L5mWtGhYHTw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=git@johnthomson.fastmail.com.au \
--cc=hofrat@osadl.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=opensource@vdorst.com \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).