From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Hector Bujanda <hector.bujanda@digi.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kent Gibson <warthog618@gmail.com>
Subject: Re: [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL
Date: Mon, 4 May 2020 15:37:24 +0300 [thread overview]
Message-ID: <CAHp75VeFCFbjr02BiwbKOAHim-xys3N1Lieyfr99xgwN5GoVLA@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=MeHun_WEApEXP59ZszGa2n+wbU9qq3wU1VO9o590rO-Pw@mail.gmail.com>
On Wed, Apr 29, 2020 at 3:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> niedz., 19 kwi 2020 o 02:19 Hector Bujanda <hector.bujanda@digi.com> napisał(a):
...
> Finally: we can extend the gpiohandle_config structure with a field
> containing the debounce time which would be read by the kernel if the
> debounce flag is set in gpiohandle_config.flags.
Don't forget the 64/32 ABI.
The configuration structure has padding / endianess issues
Should be something like
{
u32 x;
u8 y;
u8 padding8[3];
u32 padding32[2*z];
}
I.O.W. each member must have padding / endianess agnostic place along
with whole structure to be multiple of 64-bit words.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-04 12:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 0:18 [PATCH] gpiolib: add GPIO_SET_DEBOUNCE_IOCTL Hector Bujanda
2020-04-29 12:06 ` Bartosz Golaszewski
2020-04-29 12:38 ` Linus Walleij
2020-04-29 12:59 ` Bartosz Golaszewski
2020-04-30 13:32 ` Bujanda, Hector
2020-04-30 14:58 ` Kent Gibson
2020-05-04 10:31 ` Bartosz Golaszewski
2020-05-07 3:39 ` Kent Gibson
2020-05-14 14:21 ` Linus Walleij
2020-05-12 17:55 ` Linus Walleij
2020-05-13 4:33 ` Kent Gibson
2020-05-25 2:22 ` Kent Gibson
2020-05-25 12:17 ` Linus Walleij
2020-05-25 15:17 ` Kent Gibson
2020-05-27 5:31 ` Linus Walleij
2020-05-04 12:37 ` Andy Shevchenko [this message]
2020-04-19 0:22 Hector Bujanda
2020-04-28 10:35 ` Linus Walleij
2020-04-29 1:49 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeFCFbjr02BiwbKOAHim-xys3N1Lieyfr99xgwN5GoVLA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hector.bujanda@digi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).