From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI
Date: Tue, 4 May 2021 18:15:44 +0300 [thread overview]
Message-ID: <CAHp75VeLyxbwbDtCca5goCEWn7vbQ9d_Fb01dWj1CP8eBb9jJA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vc99LzOpe1EeTwoM+wkwyZkTamj6-=MSe_MBZ1+XUcebg@mail.gmail.com>
On Tue, May 4, 2021 at 6:11 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > With CONFIG_ACPI=n and -Werror, 0-day reports:
> >
> > drivers/iio/humidity/am2315.c:259:36: error:
> > 'am2315_acpi_id' defined but not used
>
> ...
>
> > +#ifdef CONFIG_ACPI
> > static const struct acpi_device_id am2315_acpi_id[] = {
> > {"AOS2315", 0},
>
> This is a fake ID according to the specification. Do we have any proof
> that it's being used in the wild?
> If no, I prefer to drop this ID section entirely.
>
> If yes, needs a comment which device is using it (however it may be
> out of the scope of this fix).
Googling shows zarro results.
(Yes, I know about meta-acpi project and I may fix it there, but it
may not be considered as a "being in the wild")
So, please, remove the entire section.
Feel free to add any tag from me (Rb, Ack)
> > {}
> > };
> > -
> > MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> > +#endif
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-04 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:30 [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI Guenter Roeck
2021-05-04 15:11 ` Andy Shevchenko
2021-05-04 15:15 ` Andy Shevchenko [this message]
2021-05-04 15:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeLyxbwbDtCca5goCEWn7vbQ9d_Fb01dWj1CP8eBb9jJA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).