From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Vadym Kochan <vadym.kochan@plvision.eu>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>, Andrew Lunn <andrew@lunn.ch>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Andrii Savka <andrii.savka@plvision.eu>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support
Date: Mon, 27 Jul 2020 18:33:45 +0300 [thread overview]
Message-ID: <CAHp75Vemcp1y3S09PVTQoyB10goZfhb1HYmeMxqiReQdQJ3JBw@mail.gmail.com> (raw)
In-Reply-To: <20200727141152.GM2216@nanopsycho>
On Mon, Jul 27, 2020 at 5:11 PM Jiri Pirko <jiri@resnulli.us> wrote:
> Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevchenko@gmail.com wrote:
> >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
...
> >> +err_prestera_dev_register:
> >> + free_irq(pci_irq_vector(pdev, 0), fw);
> >> +err_request_irq:
> >> + pci_free_irq_vectors(pdev);
> >> +err_irq_alloc:
> >> + destroy_workqueue(fw->wq);
> >> +err_wq_alloc:
> >> + prestera_fw_uninit(fw);
> >
> >> +err_prestera_fw_init:
> >> +err_pci_dev_alloc:
> >> +err_dma_mask:
> >
> >All three are useless.
>
> This is okay. It is symmetrical with init. err_what_you_init. It is all
> over the place.
We use multi-point return and these are inconsistent with the
approach. They simple LOCs without value.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-27 15:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 12:22 [net-next v4 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Vadym Kochan
2020-07-27 12:22 ` [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Vadym Kochan
2020-07-27 12:59 ` Andy Shevchenko
2020-07-31 15:22 ` Vadym Kochan
2020-07-31 16:02 ` Andy Shevchenko
2020-07-31 20:55 ` Vadym Kochan
2020-07-27 19:32 ` David Miller
2020-08-13 8:03 ` Jonathan McDowell
2020-08-14 8:20 ` Vadym Kochan
2020-08-14 12:05 ` Jonathan McDowell
2020-08-14 12:27 ` Vadym Kochan
2020-08-14 13:18 ` Andrew Lunn
2020-08-20 8:31 ` Vadym Kochan
2020-08-20 10:00 ` [EXT] " Mickey Rachamim
2020-08-22 16:34 ` Andrew Lunn
2020-08-25 11:36 ` Vadym Kochan
2020-07-27 12:22 ` [net-next v4 2/6] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-07-27 12:32 ` Jiri Pirko
2020-07-27 12:35 ` Vadym Kochan
2020-07-27 13:02 ` Jiri Pirko
2020-07-27 13:29 ` Andy Shevchenko
2020-07-27 14:11 ` Jiri Pirko
2020-07-27 15:33 ` Andy Shevchenko [this message]
2020-07-27 12:22 ` [net-next v4 3/6] net: marvell: prestera: Add basic devlink support Vadym Kochan
2020-07-27 13:07 ` Andy Shevchenko
2020-07-28 12:30 ` Vadym Kochan
2020-07-28 13:24 ` Andy Shevchenko
2020-07-27 12:22 ` [net-next v4 4/6] net: marvell: prestera: Add ethtool interface support Vadym Kochan
2020-07-27 13:17 ` Andy Shevchenko
2020-07-27 12:22 ` [net-next v4 5/6] net: marvell: prestera: Add Switchdev driver implementation Vadym Kochan
2020-07-27 12:22 ` [net-next v4 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vemcp1y3S09PVTQoyB10goZfhb1HYmeMxqiReQdQJ3JBw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=andrii.savka@plvision.eu \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.boiko@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=vadym.kochan@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).