From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] iio: am2315: Remove ACPI support
Date: Tue, 4 May 2021 18:41:02 +0300 [thread overview]
Message-ID: <CAHp75VfJ=7B3UBMns1fm7apDmCC4eakeumw4dJYdRXd5wEGkpQ@mail.gmail.com> (raw)
In-Reply-To: <20210504153746.2129428-1-linux@roeck-us.net>
On Tue, May 4, 2021 at 6:37 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/humidity/am2315.c:259:36: error:
> 'am2315_acpi_id' defined but not used
>
> According to Andy Shevchenko, the ACPI ID used in this driver is fake
> and does not really exist. Remove it and with it ACPI support from
> the driver.
As I have found zarro evidences, I agree with removal. We must not
create fake ACPI IDs on our owns. If anybody will find a device that
is using this broken ID for real, then we may add it back.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Instead of making am2315_acpi_id depend on CONFIG_ACPI,
> remove ACPI support entirely.
>
> drivers/iio/humidity/am2315.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> index 23bc9c784ef4..8d7ec2f5acf8 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -7,7 +7,6 @@
> * 7-bit I2C address: 0x5C.
> */
>
> -#include <linux/acpi.h>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
> @@ -256,17 +255,9 @@ static const struct i2c_device_id am2315_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, am2315_i2c_id);
>
> -static const struct acpi_device_id am2315_acpi_id[] = {
> - {"AOS2315", 0},
> - {}
> -};
> -
> -MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> -
> static struct i2c_driver am2315_driver = {
> .driver = {
> .name = "am2315",
> - .acpi_match_table = ACPI_PTR(am2315_acpi_id),
> },
> .probe = am2315_probe,
> .id_table = am2315_i2c_id,
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-04 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 15:37 [PATCH v2] iio: am2315: Remove ACPI support Guenter Roeck
2021-05-04 15:41 ` Andy Shevchenko [this message]
2021-05-08 15:25 ` Jonathan Cameron
2021-05-08 15:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfJ=7B3UBMns1fm7apDmCC4eakeumw4dJYdRXd5wEGkpQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).