From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Frieder Schrempf <frieder.schrempf@exceet.de>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
"boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"richard@nod.at" <richard@nod.at>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"broonie@kernel.org" <broonie@kernel.org>,
David Wolfe <david.wolfe@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>,
Han Xu <han.xu@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller
Date: Tue, 26 Jun 2018 16:18:44 +0300 [thread overview]
Message-ID: <CAHp75VfskABz+KrnLzDTYH=1cESimi++3HwQ2a1tiWkPTqf=HQ@mail.gmail.com> (raw)
In-Reply-To: <4046ba78-b6c0-c09b-43e2-e3c2e550be9f@exceet.de>
On Tue, Jun 26, 2018 at 3:26 PM, Frieder Schrempf
<frieder.schrempf@exceet.de> wrote:
> On 08.06.2018 22:27, Andy Shevchenko wrote:
>> On Fri, Jun 8, 2018 at 2:54 PM, Yogesh Narayan Gaur
>> <yogeshnarayan.gaur@nxp.com> wrote:
>>> +static int fsl_qspi_check_buswidth(struct fsl_qspi *q, u8 width) {
>>> + switch (width) {
>>> + case 1:
>>> + case 2:
>>> + case 4:
>>> + return 0;
>>> + }
>> if (!is_power_of_2(width) || width >= 8)
>> return -E...;
>>
>> return 0;
>>
>> ?
> Your proposition is a bit shorter, but I think it's slightly harder to read.
OK.
>>> +
>>> + return -ENOTSUPP;
>>> +}
>>> + for (i = 0; i < op->data.nbytes; i += 4) {
>>> + u32 val = 0;
>>> +
>>> + memcpy(&val, op->data.buf.out + i,
>>> + min_t(unsigned int, op->data.nbytes - i, 4));
>> You may easily avoid this conditional on each iteration.
> Do you mean something like this, or are there better ways?
>
> u32 val = 0;
>
> for (i = 0; i < ALIGN_DOWN(op->data.nbytes, 4); i += 4)
> {
> memcpy(&val, op->data.buf.out + i, 4);
> val = fsl_qspi_endian_xchg(q, val);
> qspi_writel(q, val, base + QUADSPI_TBDR);
> }
>
> memcpy(&val, op->data.buf.out + i, op->data.nbytes);
> val = fsl_qspi_endian_xchg(q, val);
> qspi_writel(q, val, base + QUADSPI_TBDR);
Something like this, though last part should go under
if (IS_ALIGNED(...))
(My comment was about moving out an invariant conditional)
>>> + val = fsl_qspi_endian_xchg(q, val);
>>> + qspi_writel(q, val, base + QUADSPI_TBDR);
>>> + }
>>> +MODULE_AUTHOR("Freescale Semiconductor Inc."); MODULE_AUTHOR("Boris
>>> +Brezillion <boris.brezillon@bootlin.com>"); MODULE_AUTHOR("Frieder
>>> +Schrempf <frieder.schrempf@exceet.de>"); MODULE_LICENSE("GPL v2");
>> Wrong indentation.
> What is wrong? Some newlines are missing here between the MODULE_ macros,
> but in my original patch it seems correct.
It should be like
MODULE_FOO(...);
MODULE_BAR(...);
MODULE_BAZ(...);
One macro — one line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-06-26 13:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527686082-15142-1-git-send-email-frieder.schrempf@exceet.de>
2018-05-30 13:14 ` [PATCH 01/11] spi: spi-mem: Extend the SPI mem interface to set a custom memory name Frieder Schrempf
2018-05-30 14:32 ` Boris Brezillon
2018-05-30 15:12 ` Frieder Schrempf
2018-05-30 13:14 ` [PATCH 02/11] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name Frieder Schrempf
2018-05-30 13:14 ` [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller Frieder Schrempf
2018-05-30 13:50 ` Yogesh Narayan Gaur
2018-05-30 14:24 ` Boris Brezillon
2018-06-01 9:14 ` Frieder Schrempf
2018-05-30 14:58 ` Boris Brezillon
2018-05-30 15:13 ` Frieder Schrempf
2018-06-05 15:00 ` Boris Brezillon
2018-06-08 11:54 ` Yogesh Narayan Gaur
2018-06-08 12:51 ` Boris Brezillon
2018-06-11 6:31 ` Yogesh Narayan Gaur
2018-06-11 7:46 ` Boris Brezillon
2018-06-11 9:38 ` Yogesh Narayan Gaur
2018-06-11 10:16 ` Boris Brezillon
2018-06-11 10:21 ` Yogesh Narayan Gaur
2018-06-12 6:42 ` Yogesh Narayan Gaur
2018-06-12 7:13 ` Boris Brezillon
2018-06-12 8:51 ` Yogesh Narayan Gaur
2018-06-15 12:50 ` Boris Brezillon
2018-06-15 13:42 ` Yogesh Narayan Gaur
2018-06-15 13:55 ` Boris Brezillon
2018-06-15 13:58 ` Boris Brezillon
2018-06-18 13:32 ` Yogesh Narayan Gaur
2018-06-18 19:15 ` Boris Brezillon
2018-06-19 7:10 ` Yogesh Narayan Gaur
2018-06-19 7:28 ` Boris Brezillon
2018-06-19 8:31 ` Yogesh Narayan Gaur
2018-06-19 8:46 ` Boris Brezillon
2018-06-26 8:58 ` Frieder Schrempf
2018-06-08 20:27 ` Andy Shevchenko
2018-06-26 12:26 ` Frieder Schrempf
2018-06-26 13:18 ` Andy Shevchenko [this message]
2018-06-26 13:47 ` Boris Brezillon
2018-06-26 15:42 ` Andy Shevchenko
2018-06-18 19:27 ` Boris Brezillon
2018-05-30 13:14 ` [PATCH 04/11] dt-bindings: spi: Move and adjust the bindings for the fsl-qspi driver Frieder Schrempf
2018-05-30 15:06 ` Boris Brezillon
2018-05-30 15:14 ` Frieder Schrempf
2018-05-30 13:14 ` [PATCH 05/11] ARM: dts: Reflect change of FSL QSPI driver and remove unused properties Frieder Schrempf
2018-05-30 15:10 ` Boris Brezillon
2018-06-01 9:27 ` Frieder Schrempf
2018-05-30 13:14 ` [PATCH 06/11] arm64: " Frieder Schrempf
2018-05-30 13:14 ` [PATCH 07/11] ARM: defconfig: Use the new FSL QSPI driver under the SPI framework Frieder Schrempf
2018-05-30 13:14 ` [PATCH 08/11] mtd: fsl-quadspi: Remove the driver as it was replaced by spi-fsl-qspi.c Frieder Schrempf
2018-05-30 13:14 ` [PATCH 09/11] ARM: dts: ls1021a: Remove fsl,qspi-has-second-chip as it is not used Frieder Schrempf
2018-05-30 13:14 ` [PATCH 10/11] ARM64: dts: ls1046a: " Frieder Schrempf
2018-05-30 13:14 ` [PATCH 11/11] MAINTAINERS: Move the Freescale QSPI driver to the SPI framework Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfskABz+KrnLzDTYH=1cESimi++3HwQ2a1tiWkPTqf=HQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=david.wolfe@nxp.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@nxp.com \
--cc=frieder.schrempf@exceet.de \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prabhakar.kushwaha@nxp.com \
--cc=richard@nod.at \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).