From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
kbuild-all@lists.01.org, Mark Brown <broonie@kernel.org>,
Kees Cook <keescook@chromium.org>,
Zhang Rui <rui.zhang@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
"agross@kernel.org" <agross@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 05/10] regulator: IRQ based event/error notification helpers
Date: Mon, 10 May 2021 23:20:17 +0300 [thread overview]
Message-ID: <CAHp75Vfw+5R-qN+iGC4hYSbL6phOoSZ7nuNsyroQPODxEmMaNA@mail.gmail.com> (raw)
In-Reply-To: <202105110342.Oembupaq-lkp@intel.com>
On Mon, May 10, 2021 at 10:46 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Matti,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on 6efb943b8616ec53a5e444193dccf1af9ad627b5]
>
> url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125
> base: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> config: i386-randconfig-s002-20210510 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.3-341-g8af24329-dirty
> # https://github.com/0day-ci/linux/commit/904edb46fa37ac86bc1e7a1629141e037f45ebed
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125
> git checkout 904edb46fa37ac86bc1e7a1629141e037f45ebed
> # save the attached .config to linux build tree
> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:12,
> from arch/x86/include/asm/percpu.h:27,
> from arch/x86/include/asm/current.h:6,
> from include/linux/sched.h:12,
> from include/linux/ratelimit.h:6,
> from include/linux/dev_printk.h:16,
> from include/linux/device.h:15,
> from drivers/regulator/irq_helpers.c:10:
> drivers/regulator/irq_helpers.c: In function 'regulator_notifier_isr':
> include/linux/bitops.h:35:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
> 35 | for ((bit) = find_first_bit((addr), (size)); \
> | ^~~
> drivers/regulator/irq_helpers.c:242:3: note: in expansion of macro 'for_each_set_bit'
> 242 | for_each_set_bit(j, &stat->notifs, BITS_PER_TYPE(stat->notifs))
> | ^~~~~~~~~~~~~~~~
> drivers/regulator/irq_helpers.c:244:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
Seems like missed {}
Matti, there is a serious question: how had you tested this...
(besides obvious compilation error)
Perhaps you have to fix your process somewhere to avoid missing important steps?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-10 20:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 11:26 [PATCH v9 00/10] Extend regulator notification support Matti Vaittinen
2021-05-10 11:27 ` [PATCH v9 01/10] dt_bindings: Add protection limit properties Matti Vaittinen
2021-05-10 11:28 ` [PATCH v9 02/10] reboot: Add hardware protection power-off Matti Vaittinen
2021-05-12 8:20 ` Petr Mladek
2021-05-12 12:00 ` Vaittinen, Matti
2021-05-13 8:34 ` Petr Mladek
2021-05-17 4:57 ` Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 03/10] thermal: Use generic HW-protection shutdown API Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 04/10] regulator: add warning flags Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 05/10] regulator: IRQ based event/error notification helpers Matti Vaittinen
2021-05-10 17:35 ` kernel test robot
2021-05-10 20:15 ` Andy Shevchenko
2021-05-10 19:45 ` kernel test robot
2021-05-10 20:20 ` Andy Shevchenko [this message]
2021-05-11 3:24 ` Matti Vaittinen
2021-05-11 4:54 ` Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 06/10] regulator: add property parsing and callbacks to set protection limits Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 07/10] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 08/10] regulator: bd9576: Support error reporting Matti Vaittinen
2021-05-10 11:31 ` [PATCH v9 09/10] regulator: bd9576: Fix the driver name in id table Matti Vaittinen
2021-05-10 11:31 ` [PATCH v9 10/10] MAINTAINERS: Add reviewer for regulator irq_helpers Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfw+5R-qN+iGC4hYSbL6phOoSZ7nuNsyroQPODxEmMaNA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).