From: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH for-next 3/4] epoll: struct epoll support
Date: Mon, 24 Feb 2014 11:24:28 -0800 [thread overview]
Message-ID: <CAJ3m7BphKMafsFPwQP60_OUYeo0So24GwO+J9hUvuOit2mswZQ@mail.gmail.com> (raw)
In-Reply-To: <20140224115907.07092911@lwn.net>
On 2/24/14, Jonathan Corbet <corbet@lwn.net> wrote:
> So I was just looking things over quickly, and something jumped out at
> me. In ep_control():
>
>> + } else if (!(*io) && epi) {
>> + /* delete this eventpoll entry */
>> + if (is_file_epoll(target)) {
>> + tep = target->private_data;
>> + mutex_lock_nested(&tep->mtx, 1);
>> + }
>> + if (is_file_epoll(target))
>> + mutex_lock_nested(&tep->mtx, 1);
>
> How could that possibly work? I can't imagine tep->mtx is going to
> react well to being locked a second time...
Wow...I have no idea how I missed that, must've been moving stuff
around and accidentally duplicated that somehow. Thanks for setting
me straight, this is why I like to start with an RFC :)
Appreciate the input,
Nate
next prev parent reply other threads:[~2014-02-24 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 1:42 [RFC PATCH for-next 0/4] epoll: combined control/wait syscall Nathaniel Yazdani
2014-02-24 1:42 ` [RFC PATCH for-next 1/4] epoll: struct epoll userspace definiton Nathaniel Yazdani
2014-02-24 5:29 ` Eric Wong
[not found] ` <CAJ3m7Bq1y+MLn=HFY3AADnVc2HK31+WANahiYLUcdBw=hh_2pg@mail.gmail.com>
[not found] ` <20140225101527.GA9963@dcvr.yhbt.net>
2014-02-26 0:13 ` Nathaniel Yazdani
2014-02-24 1:42 ` [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration Nathaniel Yazdani
2014-02-24 5:32 ` Eric Wong
2014-02-24 5:44 ` Nathaniel Yazdani
2014-02-25 10:30 ` Eric Wong
2014-02-25 23:44 ` Nathaniel Yazdani
2014-02-24 1:42 ` [RFC PATCH for-next 3/4] epoll: struct epoll support Nathaniel Yazdani
2014-02-24 18:59 ` Jonathan Corbet
2014-02-24 19:24 ` Nathaniel Yazdani [this message]
2014-02-24 1:42 ` [RFC PATCH for-next 4/4] epoll: epoll() syscall definition Nathaniel Yazdani
2014-02-25 10:21 ` Eric Wong
2014-02-25 23:46 ` Nathaniel Yazdani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3m7BphKMafsFPwQP60_OUYeo0So24GwO+J9hUvuOit2mswZQ@mail.gmail.com \
--to=n1ght.4nd.d4y@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).