From: Axel Rasmussen <axelrasmussen@google.com>
To: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Lokesh Gidra <lokeshgidra@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] userfaultfd: fix UFFDIO_CONTINUE ioctl request definition
Date: Tue, 1 Jun 2021 09:41:03 -0700 [thread overview]
Message-ID: <CAJHvVch713YnMA6KYPVret2p6yB_5+mfRJ_JbC2q2Afeh-KZbg@mail.gmail.com> (raw)
In-Reply-To: <20210601143432.1002481-1-glebfm@altlinux.org>
Thanks for catching this!
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
On Tue, Jun 1, 2021 at 7:34 AM Gleb Fotengauer-Malinovskiy
<glebfm@altlinux.org> wrote:
>
> This ioctl request reads from uffdio_continue structure which justifies
> _IOC_READ flag.
> See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>
> Fixes: f619147104c8 ("userfaultfd: add UFFDIO_CONTINUE ioctl")
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> Acked-by: Peter Xu <peterx@redhat.com>
> ---
> include/uapi/linux/userfaultfd.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> v2 fix commit message
>
> diff --git a/include/uapi/linux/userfaultfd.h b/include/uapi/linux/userfaultfd.h
> index bafbeb1a2624..650480f41f1d 100644
> --- a/include/uapi/linux/userfaultfd.h
> +++ b/include/uapi/linux/userfaultfd.h
> @@ -80,8 +80,8 @@
> struct uffdio_zeropage)
> #define UFFDIO_WRITEPROTECT _IOWR(UFFDIO, _UFFDIO_WRITEPROTECT, \
> struct uffdio_writeprotect)
> -#define UFFDIO_CONTINUE _IOR(UFFDIO, _UFFDIO_CONTINUE, \
> - struct uffdio_continue)
> +#define UFFDIO_CONTINUE _IOWR(UFFDIO, _UFFDIO_CONTINUE, \
> + struct uffdio_continue)
>
> /* read() structure */
> struct uffd_msg {
> --
> glebfm
>
next prev parent reply other threads:[~2021-06-01 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 14:34 [PATCH v2] userfaultfd: fix UFFDIO_CONTINUE ioctl request definition Gleb Fotengauer-Malinovskiy
2021-06-01 16:41 ` Axel Rasmussen [this message]
2021-06-23 2:42 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJHvVch713YnMA6KYPVret2p6yB_5+mfRJ_JbC2q2Afeh-KZbg@mail.gmail.com \
--to=axelrasmussen@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=glebfm@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshgidra@google.com \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).