From: Joel Fernandes <joelaf@google.com>
To: David Miller <davem@davemloft.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Chenbo Feng <fengc@google.com>,
Alison Chaiken <alison@she-devel.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"open list:BPF (Safe dynamic programs and tools)"
<netdev@vger.kernel.org>
Subject: Re: [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64
Date: Thu, 17 Aug 2017 23:55:38 -0700 [thread overview]
Message-ID: <CAJWu+orAs9X+sj6NBUEgvo5NzNCW2g=AR=K-u4Mn81VMmXB=2w@mail.gmail.com> (raw)
In-Reply-To: <20170808.203540.2238751604302920304.davem@davemloft.net>
On Tue, Aug 8, 2017 at 8:35 PM, David Miller <davem@davemloft.net> wrote:
> From: Joel Fernandes <joelaf@google.com>
> Date: Mon, 7 Aug 2017 18:20:49 -0700
>
>> On Mon, Aug 7, 2017 at 11:28 AM, David Miller <davem@davemloft.net> wrote:
>>> The amount of hellish hacks we are adding to deal with this is getting
>>> way out of control.
>>
>> I agree with you that hellish hacks are being added which is why it
>> keeps breaking. I think one of the things my series does is to add
>> back inclusion of asm headers that were previously removed (that is
>> the worst hellish hack in my opinion that existing in mainline). So in
>> that respect my patch is an improvement and makes it possible to build
>> for arm64 platforms (which is currently broken in mainline).
>
> Yeah that is a problem.
>
> Perhaps another avenue of attack is to separate "type" header files from
> stuff that has functiond declarations and inline assembler code.
I was thinking that's probably a huge undertaking if you meant doing
the above for every arch?
Also another way could be to modify clang to ignore inline asm
directives during compilation? Do you have any comments about such
approach?
thanks,
-Joel
next prev parent reply other threads:[~2017-08-18 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 13:05 [PATCH RFC v2 0/5] add arm64 cross compilation support to BPF samples Joel Fernandes
2017-08-07 13:05 ` [PATCH RFC v2 1/5] samples/bpf: Use getppid instead of getpgrp for array map stress Joel Fernandes
2017-08-07 13:05 ` [PATCH RFC v2 2/5] samples/bpf: Enable cross compiler support Joel Fernandes
2017-08-07 13:06 ` [PATCH RFC v2 3/5] samples/bpf: Fix inline asm issues building samples on arm64 Joel Fernandes
2017-08-07 13:15 ` Joel Fernandes
2017-08-07 18:28 ` David Miller
2017-08-08 1:20 ` Joel Fernandes
2017-08-09 3:35 ` David Miller
2017-08-18 6:55 ` Joel Fernandes [this message]
2017-08-07 13:06 ` [PATCH RFC v2 4/5] samples/bpf: Fix pt_regs issues when cross-compiling Joel Fernandes
2017-08-07 13:06 ` [PATCH RFC v2 5/5] samples/bpf: Add documentation on cross compilation Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJWu+orAs9X+sj6NBUEgvo5NzNCW2g=AR=K-u4Mn81VMmXB=2w@mail.gmail.com' \
--to=joelaf@google.com \
--cc=Juri.Lelli@arm.com \
--cc=alison@she-devel.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fengc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).