From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <huobean@gmail.com>,
Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Bart Van Assche <bvanassche@acm.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 2/3] driver core: Add ability to delete device links of unregistered devices
Date: Wed, 14 Jul 2021 20:26:14 +0200 [thread overview]
Message-ID: <CAJZ5v0gCiHucpwejmHEJFgzUCPvWMXfth1JEUiAvLR=U-c9DrA@mail.gmail.com> (raw)
In-Reply-To: <20210710103819.12532-3-adrian.hunter@intel.com>
On Sat, Jul 10, 2021 at 12:38 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Managed device links are deleted by device_del(). However it is possible to
> add a device link to a consumer before device_add(), and then discover an
I would say "discovering an error"
> error prevents the device from being used. In that case normally references
> to the device would be dropped and the device would be deleted. However the
> device link holds a reference to the device, so the device link and device
> remain indefinitely (unless the supplier is deleted).
>
> Amend device link removal to accept removal of a link with an
> unregistered consumer device.
>
> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Fixes: b294ff3e34490 ("scsi: ufs: core: Enable power management for wlun")
This patch by itself doesn't fix the above one, so the tag doesn't
seem to be suitable here.
Frankly, I would consider folding it into the third patch in the
series in which case please feel free to add
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
to the resulting combo patch.
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/base/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 2de8f7d8cf54..983e895d4ced 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -887,6 +887,8 @@ static void device_link_put_kref(struct device_link *link)
> {
> if (link->flags & DL_FLAG_STATELESS)
> kref_put(&link->kref, __device_link_del);
> + else if (!device_is_registered(link->consumer))
> + __device_link_del(&link->kref);
> else
> WARN(1, "Unable to drop a managed device link reference\n");
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-07-14 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 10:38 [PATCH V3 0/3] driver core: Add ability to delete device links of unregistered devices Adrian Hunter
2021-07-10 10:38 ` [PATCH V3 1/3] driver core: Prevent warning when removing a device link from unregistered consumer Adrian Hunter
2021-07-10 15:19 ` Greg Kroah-Hartman
2021-07-14 18:21 ` Rafael J. Wysocki
2021-07-14 18:22 ` Rafael J. Wysocki
2021-07-10 10:38 ` [PATCH V3 2/3] driver core: Add ability to delete device links of unregistered devices Adrian Hunter
2021-07-14 18:26 ` Rafael J. Wysocki [this message]
2021-07-10 10:38 ` [PATCH V3 3/3] scsi: ufshcd: Fix device links when BOOT WLUN fails to probe Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gCiHucpwejmHEJFgzUCPvWMXfth1JEUiAvLR=U-c9DrA@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).