From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Anupama K Patil <anupamakpatil123@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Adam <developer@arusty.dev>,
bkkarthik@pesu.pes.edu,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernelnewbies@kernelnewbies.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles
Date: Mon, 26 Apr 2021 14:00:58 +0200 [thread overview]
Message-ID: <CAJZ5v0gRv-1qYiN8EXx12iOiJvX7ORzqQfHvtWDnZLtpg6Aijg@mail.gmail.com> (raw)
In-Reply-To: <YIZIHR0ZQPXFkOH1@unreal>
On Mon, Apr 26, 2021 at 6:57 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Fri, Apr 23, 2021 at 03:08:03PM -0600, Shuah Khan wrote:
> > On 4/22/21 12:03 PM, Anupama K Patil wrote:
> > > de, e are two variables of the type 'struct proc_dir_entry'
> > > which can be removed to save memory. This also fixes a coding style
> > > issue reported by checkpatch where we are suggested to make assignment
> > > outside the if statement.
> > >
> >
> > Sounds like a reasonable change.
>
> It is unclear how much changes to ISA code are welcomed.
Real fixes and obvious cleanups are, not much more than that.
> According to the Wikipedia, even Windows Vista disabled ISA PnP by default.
> https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications
It is indeed unclear how many systems with this interface still run
Linux, but as long as the code is in the tree, there's nothing wrong
with attempting to improve it. There's no assurance that all such
patches will be applied, though.
Thanks!
next prev parent reply other threads:[~2021-04-26 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 18:03 [PATCH] drivers: pnp: proc.c: Removed unnecessary varibles Anupama K Patil
2021-04-23 21:08 ` Shuah Khan
2021-04-26 4:57 ` Leon Romanovsky
2021-04-26 12:00 ` Rafael J. Wysocki [this message]
2021-04-26 12:50 ` Leon Romanovsky
2021-04-26 17:52 ` bkkarthik
2021-04-27 4:18 ` Leon Romanovsky
2021-04-28 12:12 ` Jaroslav Kysela
2021-04-28 12:17 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gRv-1qYiN8EXx12iOiJvX7ORzqQfHvtWDnZLtpg6Aijg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=anupamakpatil123@gmail.com \
--cc=bkkarthik@pesu.pes.edu \
--cc=developer@arusty.dev \
--cc=gregkh@linuxfoundation.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=leon@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).