From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ckadabi@codeaurora.org, tsoni@codeaurora.org,
Vikram Mulukutla <markivx@codeaurora.org>
Subject: Re: [PATCH] dd: Invoke one probe retry cycle after every initcall level
Date: Mon, 23 Jul 2018 13:17:07 +0200 [thread overview]
Message-ID: <CAJZ5v0gWqx5Op-Bbg7bAYALCyBPsc=-+homAYj2Q1qd3WsqmDw@mail.gmail.com> (raw)
In-Reply-To: <1532035440-7860-1-git-send-email-rishabhb@codeaurora.org>
On Thu, Jul 19, 2018 at 11:24 PM, Rishabh Bhatnagar
<rishabhb@codeaurora.org> wrote:
> Drivers that are registered at an initcall level may have to
> wait until late_init before the probe deferral mechanism can
> retry their probe functions. It is possible that their
> dependencies were resolved much earlier, in some cases even
> before the next initcall level. Invoke one probe retry cycle
> at every _sync initcall level, allowing these drivers to be
> probed earlier.
Can you please say something about the actual use case this is
expected to address?
> Signed-off-by: Vikram Mulukutla <markivx@codeaurora.org>
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
> drivers/base/dd.c | 33 +++++++++++++++++++++++++++------
> 1 file changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 1435d72..e6a6821 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -224,23 +224,44 @@ void device_unblock_probing(void)
> driver_deferred_probe_trigger();
> }
>
> +static void enable_trigger_defer_cycle(void)
> +{
> + driver_deferred_probe_enable = true;
> + driver_deferred_probe_trigger();
> + /*
> + * Sort as many dependencies as possible before the next initcall
> + * level
> + */
> + flush_work(&deferred_probe_work);
> +}
> +
> /**
> * deferred_probe_initcall() - Enable probing of deferred devices
> *
> * We don't want to get in the way when the bulk of drivers are getting probed.
> * Instead, this initcall makes sure that deferred probing is delayed until
> - * late_initcall time.
> + * all the registered initcall functions at a particular level are completed.
> + * This function is invoked at every *_initcall_sync level.
> */
> static int deferred_probe_initcall(void)
> {
> - driver_deferred_probe_enable = true;
> - driver_deferred_probe_trigger();
> - /* Sort as many dependencies as possible before exiting initcalls */
> - flush_work(&deferred_probe_work);
> + enable_trigger_defer_cycle();
> + driver_deferred_probe_enable = false;
> + return 0;
> +}
> +arch_initcall_sync(deferred_probe_initcall);
> +subsys_initcall_sync(deferred_probe_initcall);
> +fs_initcall_sync(deferred_probe_initcall);
> +device_initcall_sync(deferred_probe_initcall);
> +
> +static int deferred_probe_enable_fn(void)
> +{
> + /* Enable deferred probing for all time */
> + enable_trigger_defer_cycle();
> initcalls_done = true;
> return 0;
> }
> -late_initcall(deferred_probe_initcall);
> +late_initcall(deferred_probe_enable_fn);
>
> /**
> * device_is_bound() - Check if device is bound to a driver
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-07-23 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:24 [PATCH] dd: Invoke one probe retry cycle after every initcall level Rishabh Bhatnagar
2018-07-23 11:17 ` Rafael J. Wysocki [this message]
2018-07-23 20:22 ` rishabhb
2018-07-24 8:24 ` Rafael J. Wysocki
2018-08-01 21:18 ` rishabhb
2018-08-01 21:21 ` Rafael J. Wysocki
[not found] ` <CA+tyz+6ZwtpKM=G5F2Do_sXWyo8r83ma19fWpn4HELiy0XT7=w@mail.gmail.com>
2018-08-02 22:20 ` Sodagudi Prasad
2018-08-06 8:53 ` Rafael J. Wysocki
2018-08-09 22:30 ` rishabhb
2018-08-10 7:10 ` Rafael J. Wysocki
2018-08-10 17:19 ` Sodagudi Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gWqx5Op-Bbg7bAYALCyBPsc=-+homAYj2Q1qd3WsqmDw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=ckadabi@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).