From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Utkarsh H Patel <utkarsh.h.patel@intel.com>,
Koba Ko <koba.ko@canonical.com>
Subject: Re: [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold
Date: Fri, 30 Jul 2021 14:13:09 +0200 [thread overview]
Message-ID: <CAJZ5v0gZ=Zk+RO_+=8hUtkeTgB9dHGcNVHsiTJdw_EZEsiKWSQ@mail.gmail.com> (raw)
In-Reply-To: <YQPUOgxldaqpxOxL@lahna>
On Fri, Jul 30, 2021 at 12:28 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Thu, Jul 29, 2021 at 04:49:10PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > PME signaling is only enabled by __pci_enable_wake() if the target
> > device can signal PME from the given target power state (to avoid
> > pointless reconfiguration of the device), but if the hierarchy above
> > the device goes into D3cold, the device itself will end up in D3cold
> > too, so if it can signal PME from D3cold, it should be enabled to
> > do so in __pci_enable_wake().
> >
> > [Note that if the device does not end up in D3cold and it cannot
> > signal PME from the original target power state, it will not signal
> > PME, so in that case the behavior does not change.]
> >
> > Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/
> > Fixes: 5bcc2fb4e815 ("PCI PM: Simplify PCI wake-up code")
> > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Also this solves the reported issue so,
>
> Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thank you!
I'll queue up these two patches for 5.15 barring any objections from Bjorn.
prev parent reply other threads:[~2021-07-30 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:46 [PATCH v1 0/2] PCI: PM: Fix handling of device that can only signal PME from D3cold Rafael J. Wysocki
2021-07-29 14:48 ` [PATCH v1 1/2] PCI: PM: Add special case handling for PCIe device wakeup Rafael J. Wysocki
2021-07-29 15:09 ` Rafael J. Wysocki
2021-07-29 15:54 ` [PATCH v1.1 1/2] PCI: PM: Avoid forcing PCI_D0 for wakeup reasons inconsistently Rafael J. Wysocki
2021-07-30 10:26 ` Mika Westerberg
2021-07-29 14:49 ` [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold Rafael J. Wysocki
2021-07-30 10:28 ` Mika Westerberg
2021-07-30 12:13 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gZ=Zk+RO_+=8hUtkeTgB9dHGcNVHsiTJdw_EZEsiKWSQ@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=helgaas@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=koba.ko@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).