From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86542C433FE for ; Fri, 10 Dec 2021 18:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245441AbhLJSjE convert rfc822-to-8bit (ORCPT ); Fri, 10 Dec 2021 13:39:04 -0500 Received: from mail-oi1-f174.google.com ([209.85.167.174]:33614 "EHLO mail-oi1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbhLJSjA (ORCPT ); Fri, 10 Dec 2021 13:39:00 -0500 Received: by mail-oi1-f174.google.com with SMTP id q25so14506367oiw.0; Fri, 10 Dec 2021 10:35:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cmWwBA8Prvw8yKg8YllQ7/9D+dqLH//9VzjE/Uy0t0I=; b=T1/HWPpmCqjZoOXrPzArHnW6919486jnuwLeXg0jqas0Gw7pOfSxrEQM69M5iCruoD aLPx6pLlMhKwqECaWRolng+5QRNmPPFTyUWLNcfdZp2emOXkatLQKphpMSeNMigcKekI 0282gYYmG6v99S5rkbDXrKXN0xO0I79/FHY/Z8CQK/6lKKLc8WE2grdbCSI7NU7+Ox2c gLf3QgLblpk8wn9dZv8zj5ZZRZjqtTksyAJGNvRYzBbIzbdYmrV5NEFu24aMF7duygQQ WDbiVOIcvdytyH6sD38xY5pElpHdQJSlO7kEVqN7ol0Xl55TkYevA19mim8hgFSmDUdS rFDQ== X-Gm-Message-State: AOAM530/atxOoYcEaBTGvUMhUD8wvOV1VGjK4hwfRYcDkt17vqKu8v6r RMRM5BBdjUBVljaoZLY0WiTrXWxUJvTPv5CANl8= X-Google-Smtp-Source: ABdhPJy55tGpIDxF+0NXDym/GuLq/jPswo3lW9bQPH3JZ5naSMZQfeBVB0yUiflqPmuJ6rchV13JR6onKlnNSicDR4M= X-Received: by 2002:aca:eb0b:: with SMTP id j11mr14005588oih.51.1639161324582; Fri, 10 Dec 2021 10:35:24 -0800 (PST) MIME-Version: 1.0 References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-8-digetx@gmail.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Fri, 10 Dec 2021 19:35:13 +0100 Message-ID: Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function prototypes To: Dmitry Osipenko Cc: "Rafael J. Wysocki" , Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , alankao@andestech.com, "K . C . Kuen-Chern Lin" , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 10, 2021 at 7:16 PM Dmitry Osipenko wrote: > > 10.12.2021 21:09, Rafael J. Wysocki пишет: > > On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko wrote: > >> > >> There is no need to annotate function prototypes with 'extern', it makes > >> code less readable. Remove unnecessary annotations from . > >> > >> Signed-off-by: Dmitry Osipenko > > > > I'm not sure that this is really useful. > > > > Personally, I tend to respect the existing conventions like this. > > > > Surely, this change is not required for the rest of the series to work. > > Problem that such things start to spread all over the kernel with a > copy-paste approach if there is nobody to clean up the code. > > This is not a common convention and sometimes it's getting corrected [1]. > > [1] https://git.kernel.org/linus/6d7434931 In separate patches outside of series adding new features, if one is so inclined.