From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Doug Smythies <dsmythies@telus.net>,
Giovanni Gherdovich <ggherdovich@suse.com>
Subject: Re: [PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback
Date: Tue, 8 Dec 2020 18:10:56 +0100 [thread overview]
Message-ID: <CAJZ5v0h6KM1V2_JoN+WFxAq8pKvOfsOcCVXYchUzb4xyfdzsGw@mail.gmail.com> (raw)
In-Reply-To: <20201208124344.GX2414@hirez.programming.kicks-ass.net>
On Tue, Dec 8, 2020 at 1:44 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Dec 07, 2020 at 05:38:58PM +0100, Rafael J. Wysocki wrote:
>
> > +static void intel_cpufreq_adjust_perf(unsigned int cpunum,
> > + unsigned long min_perf,
> > + unsigned long target_perf,
> > + unsigned long capacity)
> > +{
> > + struct cpudata *cpu = all_cpu_data[cpunum];
> > + int old_pstate = cpu->pstate.current_pstate;
> > + int cap_pstate, min_pstate, max_pstate, target_pstate;
> > +
> > + update_turbo_state();
> > + cap_pstate = global.turbo_disabled ? cpu->pstate.max_pstate :
> > + cpu->pstate.turbo_pstate;
> > +
> > + /* Optimization: Avoid unnecessary divisions. */
> > +
> > + target_pstate = cap_pstate;
> > + if (target_perf < capacity)
> > + target_pstate = DIV_ROUND_UP(cap_pstate * target_perf, capacity);
> > +
> > + min_pstate = cap_pstate;
> > + if (min_perf < capacity)
> > + min_pstate = DIV_ROUND_UP(cap_pstate * min_perf, capacity);
> > +
> > + if (min_pstate < cpu->pstate.min_pstate)
> > + min_pstate = cpu->pstate.min_pstate;
> > +
> > + if (min_pstate < cpu->min_perf_ratio)
> > + min_pstate = cpu->min_perf_ratio;
> > +
> > + max_pstate = min(cap_pstate, cpu->max_perf_ratio);
> > + if (max_pstate < min_pstate)
> > + max_pstate = min_pstate;
> > +
> > + target_pstate = clamp_t(int, target_pstate, min_pstate, max_pstate);
> > +
> > + intel_cpufreq_adjust_hwp(cpu, min_pstate, max_pstate, target_pstate, true);
>
> I'm confused... HWP doesn't do pstate, yet everything here is now called
> pstate, help?
HWP.REQ.MIN, HWP.REQ.MAX and HWP.REQ.DESIRED all are in the same space
of values as the original PERF_CTL MSR, which is P-states, at least
effectively.
> > +
> > + cpu->pstate.current_pstate = target_pstate;
> > + intel_cpufreq_trace(cpu, INTEL_PSTATE_TRACE_FAST_SWITCH, old_pstate);
> > +}
next prev parent reply other threads:[~2020-12-08 17:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 16:25 [PATCH v1 0/4] cpufreq: Allow drivers to receive more information from the governor Rafael J. Wysocki
2020-12-07 16:28 ` [PATCH v1 1/4] cpufreq: schedutil: Add util to struct sg_cpu Rafael J. Wysocki
2020-12-08 8:33 ` Viresh Kumar
2020-12-09 17:17 ` Rafael J. Wysocki
2020-12-07 16:29 ` [PATCH v1 2/4] cpufreq: schedutil: Adjust utilization instead of frequency Rafael J. Wysocki
2020-12-08 8:51 ` Viresh Kumar
2020-12-08 17:01 ` Rafael J. Wysocki
2020-12-09 5:16 ` Viresh Kumar
2020-12-09 15:32 ` Rafael J. Wysocki
2020-12-14 11:07 ` Viresh Kumar
2020-12-07 16:35 ` [PATCH v1 3/4] cpufreq: Add special-purpose fast-switching callback for drivers Rafael J. Wysocki
2020-12-08 9:02 ` Viresh Kumar
2020-12-15 4:16 ` Viresh Kumar
2020-12-15 15:38 ` Rafael J. Wysocki
2020-12-07 16:38 ` [PATCH v1 4/4] cpufreq: intel_pstate: Implement the ->adjust_perf() callback Rafael J. Wysocki
2020-12-08 12:43 ` Peter Zijlstra
2020-12-08 17:10 ` Rafael J. Wysocki [this message]
2020-12-08 16:30 ` [PATCH v1 0/4] cpufreq: Allow drivers to receive more information from the governor Giovanni Gherdovich
2020-12-08 17:13 ` Rafael J. Wysocki
2020-12-08 19:14 ` Doug Smythies
2020-12-13 19:12 ` Doug Smythies
2020-12-18 15:32 ` Peter Zijlstra
2020-12-14 20:01 ` [PATCH v2 0/3] " Rafael J. Wysocki
2020-12-14 20:04 ` [PATCH v2 1/3] cpufreq: schedutil: Add util to struct sg_cpu Rafael J. Wysocki
2020-12-14 20:08 ` [PATCH v2 2/3] cpufreq: Add special-purpose fast-switching callback for drivers Rafael J. Wysocki
2020-12-14 20:09 ` [PATCH v2 3/3] cpufreq: intel_pstate: Implement the ->adjust_perf() callback Rafael J. Wysocki
2020-12-15 3:29 ` Srinivas Pandruvada
2020-12-15 4:16 ` [PATCH v2 0/3] cpufreq: Allow drivers to receive more information from the governor Viresh Kumar
2020-12-17 15:26 ` Doug Smythies
2020-12-21 10:41 ` Rafael J. Wysocki
2020-12-18 16:11 ` Giovanni Gherdovich
2020-12-21 16:11 ` Rafael J. Wysocki
2020-12-23 13:06 ` Giovanni Gherdovich
2020-12-28 19:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0h6KM1V2_JoN+WFxAq8pKvOfsOcCVXYchUzb4xyfdzsGw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=dsmythies@telus.net \
--cc=ggherdovich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).