From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Doug Smythies <dsmythies@telus.net>,
Giovanni Gherdovich <ggherdovich@suse.com>
Subject: Re: [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers
Date: Mon, 7 Dec 2020 14:40:52 +0100 [thread overview]
Message-ID: <CAJZ5v0havcy_SZ6yUqjn4KK8=8SMJRSkhgaTm==eMeEinxDN2w@mail.gmail.com> (raw)
In-Reply-To: <20201207074615.kmvy5afoolhv5cgq@vireshk-i7>
On Mon, Dec 7, 2020 at 8:47 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 30-11-20, 19:37, Rafael J. Wysocki wrote:
> > Index: linux-pm/include/linux/cpufreq.h
> > ===================================================================
> > --- linux-pm.orig/include/linux/cpufreq.h
> > +++ linux-pm/include/linux/cpufreq.h
> > @@ -320,6 +320,15 @@ struct cpufreq_driver {
> > unsigned int index);
> > unsigned int (*fast_switch)(struct cpufreq_policy *policy,
> > unsigned int target_freq);
> > + /*
> > + * ->fast_switch() replacement for drivers that use an internal
> > + * representation of performance levels and can pass hints other than
> > + * the target performance level to the hardware.
> > + */
> > + void (*adjust_perf)(unsigned int cpu, bool busy,
>
> Maybe this should still take policy as an argument (like other calls)
> instead of CPU, even if it is going to be used for single-cpu per
> policy case for now.
That can be changed in the future if need be.
Otherwise this path doesn't need to look at the policy object at all
and I'd rather keep it this way.
>
> > + unsigned long min_perf,
> > + unsigned long target_perf,
> > + unsigned long capacity);
>
> --
next prev parent reply other threads:[~2020-12-07 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 18:33 [RFC][PATCH 0/2] cpufreq: Allow drivers to receive more information from the governor Rafael J. Wysocki
2020-11-30 18:37 ` [RFC][PATCH 1/2] cpufreq: Add special-purpose fast-switching callback for drivers Rafael J. Wysocki
2020-12-02 15:58 ` Doug Smythies
2020-12-02 17:39 ` Rafael J. Wysocki
2020-12-03 12:41 ` Peter Zijlstra
2020-12-03 14:44 ` Rafael J. Wysocki
2020-12-07 7:46 ` Viresh Kumar
2020-12-07 13:40 ` Rafael J. Wysocki [this message]
2020-11-30 18:37 ` [RFC][PATCH 2/2] cpufreq: intel_pstate: Implement the ->adjust_perf() callback Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0havcy_SZ6yUqjn4KK8=8SMJRSkhgaTm==eMeEinxDN2w@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=dsmythies@telus.net \
--cc=ggherdovich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).