From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
Michael Larabel <Michael@phoronix.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v1 2/2] cpufreq: ACPI: Update arch scale-invariance max perf ratio if CPPC is not there
Date: Fri, 5 Feb 2021 13:23:08 +0100 [thread overview]
Message-ID: <CAJZ5v0iY17AYbgfPoxKn27MiRZ_KR2iMZZVk6UNV38geec84sQ@mail.gmail.com> (raw)
In-Reply-To: <YB0yYQl6T2fIQ+hw@hirez.programming.kicks-ass.net>
On Fri, Feb 5, 2021 at 12:59 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Feb 04, 2021 at 06:34:32PM +0100, Rafael J. Wysocki wrote:
>
> > arch/x86/kernel/smpboot.c | 1 +
> > drivers/cpufreq/acpi-cpufreq.c | 8 ++++++++
> > 2 files changed, 9 insertions(+)
> >
> > Index: linux-pm/drivers/cpufreq/acpi-cpufreq.c
> > ===================================================================
> > --- linux-pm.orig/drivers/cpufreq/acpi-cpufreq.c
> > +++ linux-pm/drivers/cpufreq/acpi-cpufreq.c
> > @@ -806,6 +806,14 @@ static int acpi_cpufreq_cpu_init(struct
> > state_count++;
> > valid_states++;
> > data->first_perf_state = valid_states;
> > + } else {
> > + /*
> > + * If the maximum "boost" frequency is unknown, ask the arch
> > + * scale-invariance code to use the "nominal" performance for
> > + * CPU utilization scaling so as to prevent the schedutil
> > + * governor from selecting inadequate CPU frequencies.
> > + */
> > + arch_set_max_freq_ratio(true);
> > }
> >
> > freq_table = kcalloc(state_count, sizeof(*freq_table), GFP_KERNEL);
> > Index: linux-pm/arch/x86/kernel/smpboot.c
> > ===================================================================
> > --- linux-pm.orig/arch/x86/kernel/smpboot.c
> > +++ linux-pm/arch/x86/kernel/smpboot.c
> > @@ -1833,6 +1833,7 @@ void arch_set_max_freq_ratio(bool turbo_
> > arch_max_freq_ratio = turbo_disabled ? SCHED_CAPACITY_SCALE :
> > arch_turbo_freq_ratio;
> > }
> > +EXPORT_SYMBOL_GPL(arch_set_max_freq_ratio);
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Thanks, I'm queuing up this lot for a post-rc7 late push.
prev parent reply other threads:[~2021-02-05 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:23 [PATCH v1 0/2] cpufreq: ACPI: Address performance regression related to scale-invariance Rafael J. Wysocki
2021-02-04 17:25 ` [PATCH v1 1/2] cpufreq: ACPI: Extend frequency tables to cover boost frequencies Rafael J. Wysocki
2021-02-05 7:06 ` Giovanni Gherdovich
2021-02-04 17:34 ` [PATCH v1 2/2] cpufreq: ACPI: Update arch scale-invariance max perf ratio if CPPC is not there Rafael J. Wysocki
2021-02-05 7:07 ` Giovanni Gherdovich
2021-02-05 11:56 ` Peter Zijlstra
2021-02-05 12:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iY17AYbgfPoxKn27MiRZ_KR2iMZZVk6UNV38geec84sQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=Michael@phoronix.com \
--cc=ggherdovich@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).