From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: LKML <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Eric Engestrom <eric.engestrom@intel.com>
Subject: Re: [PATCH] cpufreq: use for_each_if
Date: Mon, 9 Jul 2018 23:36:47 +0200 [thread overview]
Message-ID: <CAJZ5v0jzc-V1GWAQbYUTbYQVm_DGZp1GpwAq158uW6Z6Sv++uA@mail.gmail.com> (raw)
In-Reply-To: <20180709161129.28425-1-daniel.vetter@ffwll.ch>
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Avoids the inverted condition compared to the open coded version.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Eric Engestrom <eric.engestrom@intel.com>
> --
> v2: Fix the logic fumble in the 2nd hunk, spotted by Eric.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Or do you want me to apply it?
> ---
> include/linux/cpufreq.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 882a9b9e34bc..3a774f523d00 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -649,9 +649,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry(pos, table) \
> for (pos = table; pos->frequency != CPUFREQ_TABLE_END; pos++) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
> /*
> * cpufreq_for_each_valid_entry_idx - iterate with index over a cpufreq
> @@ -663,9 +661,7 @@ static inline void dev_pm_opp_free_cpufreq_table(struct device *dev,
>
> #define cpufreq_for_each_valid_entry_idx(pos, table, idx) \
> cpufreq_for_each_entry_idx(pos, table, idx) \
> - if (pos->frequency == CPUFREQ_ENTRY_INVALID) \
> - continue; \
> - else
> + for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)
>
>
> int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-07-09 21:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:36 [PATCH 01/12] kernel.h: Add for_each_if() Daniel Vetter
2018-07-09 8:36 ` [PATCH 02/12] blk: use for_each_if Daniel Vetter
2018-07-11 16:40 ` Tejun Heo
2018-07-11 16:45 ` Tejun Heo
2018-07-11 18:30 ` Jens Axboe
2018-07-11 18:50 ` Daniel Vetter
2018-07-11 19:31 ` Jens Axboe
2018-07-11 20:06 ` Tejun Heo
2018-07-11 21:08 ` Daniel Vetter
2018-07-11 21:13 ` Jens Axboe
2018-07-12 6:41 ` Daniel Vetter
2018-07-12 6:45 ` Joe Perches
2018-07-12 13:54 ` Jens Axboe
2018-07-12 15:32 ` Joe Perches
2018-07-13 9:28 ` Vlastimil Babka
2018-07-09 8:36 ` [PATCH 03/12] cgroup: " Daniel Vetter
2018-07-11 16:46 ` Tejun Heo
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: " Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
2018-07-09 21:36 ` Rafael J. Wysocki [this message]
2018-07-09 8:36 ` [PATCH 05/12] dmar: Use for_each_If Daniel Vetter
2018-07-20 12:50 ` Joerg Roedel
2018-07-09 8:36 ` [PATCH 06/12] mm: use for_each_if Daniel Vetter
2018-07-09 18:00 ` Pavel Tatashin
2018-07-09 8:36 ` [PATCH 07/12] ide: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 08/12] netdev: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 09/12] nubus: " Daniel Vetter
2018-07-09 10:17 ` Finn Thain
2018-07-17 15:26 ` Geert Uytterhoeven
2018-07-09 8:36 ` [PATCH 10/12] pci: " Daniel Vetter
2018-07-09 22:48 ` Bjorn Helgaas
2018-07-09 8:36 ` [PATCH 11/12] sched: use for_each_if in topology.h Daniel Vetter
2018-07-09 10:36 ` Peter Zijlstra
2018-07-09 15:00 ` Daniel Vetter
2018-07-09 15:12 ` Peter Zijlstra
2018-07-09 15:52 ` Daniel Vetter
2018-07-09 16:03 ` Peter Zijlstra
2018-07-09 16:06 ` Daniel Vetter
2018-07-09 16:12 ` Mark Rutland
2018-07-09 17:55 ` [Intel-gfx] " Daniel Vetter
2018-07-11 16:51 ` Mark Rutland
2018-07-09 16:30 ` Peter Zijlstra
2018-07-09 8:36 ` [PATCH 12/12] usb: use for_each_if Daniel Vetter
2018-07-09 11:50 ` [PATCH 01/12] kernel.h: Add for_each_if() Andy Shevchenko
2018-07-09 16:25 ` [PATCH] " Daniel Vetter
2018-07-09 18:30 ` Andy Shevchenko
2018-07-09 23:30 ` Andrew Morton
2018-07-10 7:53 ` Daniel Vetter
2018-07-10 10:32 ` NeilBrown
2018-07-11 11:51 ` Daniel Vetter
2018-07-11 23:05 ` Andrew Morton
2018-07-12 6:39 ` Daniel Vetter
2018-07-13 23:37 ` NeilBrown
2018-07-13 23:42 ` Randy Dunlap
2018-07-16 8:11 ` Andy Shevchenko
2018-07-16 15:41 ` Randy Dunlap
2018-07-16 22:16 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jzc-V1GWAQbYUTbYQVm_DGZp1GpwAq158uW6Z6Sv++uA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.engestrom@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).