linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hillf Danton <dhillf@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Hugh Dickins <hughd@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix malused nr_reclaimed in shrinking zone
Date: Thu, 26 Jan 2012 11:19:17 +0800	[thread overview]
Message-ID: <CAJd=RBCv1F3oWpnEbqrvOaRzg_G6Xj_PPHP8v6OADL=vH2pt8g@mail.gmail.com> (raw)
In-Reply-To: <20120125170054.affb676b.akpm@linux-foundation.org>

Hi Andrew

On Thu, Jan 26, 2012 at 9:00 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> I'm thinking we have a bit of code rot happening here.  This comment:
>
>                /*
>                 * On large memory systems, scan >> priority can become
>                 * really large. This is fine for the starting priority;
>                 * we want to put equal scanning pressure on each zone.
>                 * However, if the VM has a harder time of freeing pages,
>                 * with multiple processes reclaiming pages, the total
>                 * freeing target can get unreasonably large.
>                 */
>
> seems to have little to do with the code which it is trying to
> describe.  Or at least, I'm not sure this is the best we can possibly
> do :(
>

Try to do it soon 8-)

>
> Also, your email client is adding MIME goop to the emails which mine
> (sylpheed) is unable to decrypt.  It turns "=" into "=3D" everywhere.
> This:
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> I blame sylpheed for this, but if you can make it stop, that would make
> my life easier, and perhaps others.
>

More care will take gmail later on.

Thanks
Hillf

      reply	other threads:[~2012-01-26  3:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-21 14:41 [PATCH] mm: vmscan: fix malused nr_reclaimed in shrinking zone Hillf Danton
2012-01-24  1:03 ` Andrew Morton
2012-01-24 11:00   ` Hillf Danton
2012-01-26  1:00     ` Andrew Morton
2012-01-26  3:19       ` Hillf Danton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJd=RBCv1F3oWpnEbqrvOaRzg_G6Xj_PPHP8v6OADL=vH2pt8g@mail.gmail.com' \
    --to=dhillf@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).