From: jim.cromie@gmail.com
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Zhenyu Wang" <zhenyuw@linux.intel.com>,
"Zhi Wang" <zhi.a.wang@intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Jason Baron" <jbaron@akamai.com>,
"Ashley Thomas" <Ashley.Thomas2@amd.com>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Wyatt Wood" <Wyatt.Wood@amd.com>,
"Johan Hovold" <johan@kernel.org>, "Jessica Yu" <jeyu@kernel.org>,
"Joe Perches" <joe@perches.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nick Desaulniers" <ndesaulniers@gooogle.com>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
intel-gvt-dev@lists.freedesktop.org,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks
Date: Mon, 2 Aug 2021 12:40:32 -0600 [thread overview]
Message-ID: <CAJfuBxzbKKnjfw72GVy531TOQjd9znqkoxOq_UTRZyxOyxXPXg@mail.gmail.com> (raw)
In-Reply-To: <CACvgo509FWgNcBP9SPyuZV0Wey9sApmgB2Xa_+LJ4r91Cgqhgg@mail.gmail.com>
On Mon, Aug 2, 2021 at 10:24 AM Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> Hi Jim,
>
> On Sat, 31 Jul 2021 at 22:42, Jim Cromie <jim.cromie@gmail.com> wrote:
>
> > +struct dyndbg_bitdesc {
> > + /* bitpos is inferred from index in containing array */
> > + char *prefix;
> > + char *help;
> AFAICT these two should also be constant, right?
>
>
> > +int param_set_dyndbg(const char *instr, const struct kernel_param *kp)
> > +{
> > + unsigned int val;
> > + unsigned long changes, result;
> > + int rc, chgct = 0, totct = 0, bitpos, bitsmax;
> > + char query[OUR_QUERY_SIZE];
> > + struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;
> > +
> > + // pr_info("set_dyndbg: instr: %s curr: %d\n", instr, *kp->arg);
> Left-over debug code, here and below?
yup, all fixed up locally, with a version that fully works.
thanks.
>
> -Emil
next prev parent reply other threads:[~2021-08-02 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 21:41 [PATCH v4 0/7] drm: use dyndbg in drm_print Jim Cromie
2021-07-31 21:41 ` [PATCH v4 1/7] drm/print: fixup spelling in a comment Jim Cromie
2021-07-31 21:41 ` [PATCH v4 2/7] moduleparam: add data member to struct kernel_param Jim Cromie
2021-08-02 16:18 ` Emil Velikov
2021-08-02 18:36 ` jim.cromie
2021-07-31 21:42 ` [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks Jim Cromie
2021-08-02 16:24 ` [Intel-gfx] " Emil Velikov
2021-08-02 18:40 ` jim.cromie [this message]
2021-07-31 21:42 ` [PATCH v4 4/7] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes Jim Cromie
2021-07-31 21:42 ` [PATCH v4 5/7] i915/gvt: control pr_debug("gvt:")s with bits in parameters/debug_gvt Jim Cromie
2021-08-02 16:27 ` Emil Velikov
2021-07-31 21:42 ` [PATCH v4 6/7] drm/print: add choice to use dynamic debug in drm-debug Jim Cromie
2021-07-31 21:42 ` [PATCH v4 7/7] amdgpu: define a dydbg-bitmap to control categorized pr_debugs Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfuBxzbKKnjfw72GVy531TOQjd9znqkoxOq_UTRZyxOyxXPXg@mail.gmail.com \
--to=jim.cromie@gmail.com \
--cc=Ashley.Thomas2@amd.com \
--cc=Wyatt.Wood@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ndesaulniers@gooogle.com \
--cc=ojeda@kernel.org \
--cc=qingqing.zhuo@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).