From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751978AbdLBB1s (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Dec 2017 20:27:48 -0500
Received: from mail-io0-f196.google.com ([209.85.223.196]:38622 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751468AbdLBB1r (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Dec 2017 20:27:47 -0500
X-Google-Smtp-Source: AGs4zMYhq51xqu6PW/RZ2ODmPGtCD9LMl2EWyMoFsPMW8F+U2rs2+oS1Kfn5NwwJgMhobMfP2nD1rWWMVYcct8oW/DA=
MIME-Version: 1.0
In-Reply-To: <1512157320-23205-2-git-send-email-paulmck@linux.vnet.ibm.com>
References: <20171201194139.GA22722@linux.vnet.ibm.com> <1512157320-23205-2-git-send-email-paulmck@linux.vnet.ibm.com>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Sat, 2 Dec 2017 09:27:46 +0800
Message-ID: <CAJhGHyC_U431HwtmW2GN76bDqy2DiwyQ+j3NDWB9KaSyYj-c0A@mail.gmail.com>
Subject: Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Howells <dhowells@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= <fweisbec@gmail.com>,
        oleg@redhat.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 2, 2017 at 3:41 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> This commit changes the %p printk() in rcutorture to %pK.  This could
> be considered irrelevant, given that any user able to start rcutorture
> could inflict far heavier damage on the system, but it doesn't hurt to
> change it and doing so avoids script-generated noise.
>
> Reported-by: Tobin C. Harding <me@tobin.cc>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

> ---
>  kernel/rcu/srcutree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index d5cea81378cc..81f2eb78c504 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -386,7 +386,7 @@ void cleanup_srcu_struct(struct srcu_struct *sp)
>                 flush_delayed_work(&per_cpu_ptr(sp->sda, cpu)->work);
>         if (WARN_ON(rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)) != SRCU_STATE_IDLE) ||
>             WARN_ON(srcu_readers_active(sp))) {
> -               pr_info("cleanup_srcu_struct: Active srcu_struct %p state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> +               pr_info("cleanup_srcu_struct: Active srcu_struct %pK state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
>                 return; /* Caller forgot to stop doing call_srcu()? */
>         }
>         free_percpu(sp->sda);
> --
> 2.5.2
>