From: "Clément Péron" <peron.clem@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Adrien Charruel <adrien.charruel@devialet.com>
Subject: Re: [PATCH 1/2] ASoC: ak4118: Add support for AK4118 S/PDIF transceiver
Date: Thu, 15 Nov 2018 17:31:44 +0100 [thread overview]
Message-ID: <CAJiuCccTwxA4Am=H5vMw9PBJQi_+ErSPEsT5C7PRpv_b6y9EPA@mail.gmail.com> (raw)
In-Reply-To: <20181114173129.GY2089@sirena.org.uk>
Hi Mark,
On Wed, 14 Nov 2018 at 18:31, Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Nov 14, 2018 at 11:55:17AM +0100, Clément Péron wrote:
> > On Tue, 13 Nov 2018 at 23:51, Mark Brown <broonie@kernel.org> wrote:
> > > On Thu, Nov 08, 2018 at 01:49:33PM +0100, Clément Péron wrote:
>
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +/*
> > > > + * ak4118.c -- Asahi Kasei ALSA Soc Audio driver
> > > > + *
>
> > > Please make the entire comment a C++ one so this looks more intentional.
>
> > I check from other files and also this article says :
> > "For normal C source files, the string will be a comment using the
> > "//" syntax; header files, instead, use traditional (/* */) comments
> > for reasons related to tooling"
> > https://lwn.net/Articles/739183/
>
> Right, and what I said was that you should make the entire comment a C++
> one which means that the magic line will be C++ as required.
Yes, sorry I was confused between C++ and C99,
Regards,
Clement
prev parent reply other threads:[~2018-11-15 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 12:49 [PATCH 1/2] ASoC: ak4118: Add support for AK4118 S/PDIF transceiver Clément Péron
2018-11-08 12:49 ` [PATCH 2/2] ASoC: dt-bindings: add bindings for AK4118 transceiver Clément Péron
2018-11-13 22:51 ` [PATCH 1/2] ASoC: ak4118: Add support for AK4118 S/PDIF transceiver Mark Brown
2018-11-14 10:55 ` Clément Péron
2018-11-14 17:31 ` Mark Brown
2018-11-15 16:31 ` Clément Péron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJiuCccTwxA4Am=H5vMw9PBJQi_+ErSPEsT5C7PRpv_b6y9EPA@mail.gmail.com' \
--to=peron.clem@gmail.com \
--cc=adrien.charruel@devialet.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).