From: Len Brown <lenb@kernel.org>
To: Calvin Walton <calvin.walton@kepstin.ca>
Cc: Linux PM list <linux-pm@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] [WIP] tools/power turbostat: Also read package power on AMD F17h (Zen)
Date: Wed, 20 Mar 2019 19:36:55 -0400 [thread overview]
Message-ID: <CAJvTdKmXSQyY-Jdv7OkseHEE-76oDPLeJ8v8ShApDRKqWsukSQ@mail.gmail.com> (raw)
In-Reply-To: <20180817163442.10065-3-calvin.walton@kepstin.ca>
Hi Calvin,
I'm inclined to apply this -- because it will not break anything,
and it would at least enable testing by people, who have this hardware.
thoughts?
-Len
On Fri, Aug 17, 2018 at 12:35 PM Calvin Walton <calvin.walton@kepstin.ca> wrote:
>
> The package power can also be read from an MSR. It's not clear exactly
> what is included, and whether it's aggregated over all nodes or
> reported separately.
>
> It does look like this is reported separately per CCX (I get a single
> value on the Ryzen R7 1700), but it might be reported separately per-
> die (node?) on larger processors. If that's the case, it would have to
> be recorded per node and aggregated for the socket.
>
> Note that although Zen has these MSRs reporting power, it looks like
> the actual RAPL configuration (power limits, configured TDP) is done
> through PCI configuration space. I have not yet found any public
> documentation for this.
>
> Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
> ---
> tools/power/x86/turbostat/turbostat.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 89d4e2e75774..675c894b8595 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -1973,6 +1973,11 @@ int get_counters(struct thread_data *t, struct core_data *c, struct pkg_data *p)
> return -16;
> p->rapl_dram_perf_status = msr & 0xFFFFFFFF;
> }
> + if (do_rapl & RAPL_AMD_F17H) {
> + if (get_msr(cpu, MSR_PKG_ENERGY_STAT, &msr))
> + return -13;
> + p->energy_pkg = msr & 0xFFFFFFFF;
> + }
> if (DO_BIC(BIC_PkgTmp)) {
> if (get_msr(cpu, MSR_IA32_PACKAGE_THERM_STATUS, &msr))
> return -17;
> @@ -3986,10 +3991,13 @@ void rapl_probe_amd(unsigned int family, unsigned int model)
> switch (family) {
> case 0x17: /* Zen, Zen+ */
> do_rapl = RAPL_AMD_F17H | RAPL_PER_CORE_ENERGY;
> - if (rapl_joules)
> + if (rapl_joules) {
> + BIC_PRESENT(BIC_Pkg_J);
> BIC_PRESENT(BIC_Cor_J);
> - else
> + } else {
> + BIC_PRESENT(BIC_PkgWatt);
> BIC_PRESENT(BIC_CorWatt);
> + }
> break;
> default:
> return;
> --
> 2.18.0
>
--
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2019-03-20 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 16:34 [PATCH v3 0/2] tools/power turbostat: Add support for AMD Fam 17h (Zen) RAPL Calvin Walton
2018-08-17 16:34 ` [PATCH v3 1/2] " Calvin Walton
2018-08-17 16:34 ` [PATCH v3 2/2] [WIP] tools/power turbostat: Also read package power on AMD F17h (Zen) Calvin Walton
2019-03-20 23:36 ` Len Brown [this message]
2019-03-21 1:35 ` Calvin Walton
2019-03-21 3:09 ` Len Brown
2019-03-20 23:35 ` [PATCH v3 0/2] tools/power turbostat: Add support for AMD Fam 17h (Zen) RAPL Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvTdKmXSQyY-Jdv7OkseHEE-76oDPLeJ8v8ShApDRKqWsukSQ@mail.gmail.com \
--to=lenb@kernel.org \
--cc=calvin.walton@kepstin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).