From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>,
Arvind Sankar <nivedita@alum.mit.edu>
Cc: Fangrui Song <maskray@google.com>,
Rong Chen <rong.a.chen@intel.com>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Makefile: Improve compressed debug info support detection
Date: Sun, 14 Jun 2020 11:21:07 +0900 [thread overview]
Message-ID: <CAK7LNAQAZ3PFvvj7M_AYZKo4uwui1DaJyjebWLmpnp-ism_=mQ@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdksFqf11-sdLrvNe4wrRvyAB2mVfwKU4KkNsapSnN_tRw@mail.gmail.com>
On Fri, Jun 12, 2020 at 8:39 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Thu, Jun 11, 2020 at 3:03 PM Arvind Sankar <nivedita@alum.mit.edu> wrote:
> >
> > Commit
> > 10e68b02c861 ("Makefile: support compressed debug info")
> > added support for compressed debug sections.
> >
> > Support is detected by checking
> > - does the compiler support -gz=zlib
> > - does the assembler support --compressed-debug-sections=zlib
> > - does the linker support --compressed-debug-sections=zlib
> >
> > However, the gcc driver's support for this option is somewhat
> > convoluted. The driver's builtin specs are set based on the version of
> > binutils that it was configured with. It reports an error if the
> > configure-time linker/assembler (i.e., not necessarily the actual
> > assembler that will be run) do not support the option, but only if the
> > assembler (or linker) is actually invoked when -gz=zlib is passed.
> >
> > The cc-option check in scripts/Kconfig.include does not invoke the
> > assembler, so the gcc driver reports success even if it does not support
> > the option being passed to the assembler.
> >
> > Because the as-option check passes the option directly to the assembler
> > via -Wa,--compressed-debug-sections=zlib, the gcc driver does not see
> > this option and will never report an error.
>
> Thanks for expanding on the failure.
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
Applied to linux-kbuild/fixes.
Thanks.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-06-14 2:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 13:11 gcc-5: error: -gz is not supported in this configuration kernel test robot
2020-06-09 17:28 ` Nick Desaulniers
2020-06-09 17:49 ` Fangrui Song
2020-06-10 0:30 ` [kbuild-all] " Rong Chen
2020-06-10 0:58 ` Fangrui Song
2020-06-10 1:49 ` Rong Chen
2020-06-10 3:12 ` Arvind Sankar
2020-06-10 3:23 ` Arvind Sankar
2020-06-10 4:26 ` Arvind Sankar
2020-06-10 6:37 ` Fangrui Song
2020-06-10 19:11 ` [PATCH] Makefile: Improve compressed debug info support detection Arvind Sankar
2020-06-10 21:27 ` Nick Desaulniers
2020-06-10 23:30 ` Arvind Sankar
2020-06-10 23:39 ` Arvind Sankar
2020-06-11 20:44 ` Nick Desaulniers
2020-06-11 21:44 ` Arvind Sankar
2020-06-11 21:09 ` Nick Desaulniers
2020-06-11 21:52 ` Arvind Sankar
2020-06-11 22:03 ` [PATCH v2] " Arvind Sankar
2020-06-11 23:38 ` Nick Desaulniers
2020-06-14 2:21 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAQAZ3PFvvj7M_AYZKo4uwui1DaJyjebWLmpnp-ism_=mQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maskray@google.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).