From: Masahiro Yamada <masahiroy@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-hardening@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Justin Forbes <jforbes@redhat.com>,
Ondrej Mosnacek <omosnace@redhat.com>,
Frank Eigler <fche@redhat.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules
Date: Sat, 6 Mar 2021 01:03:32 +0900 [thread overview]
Message-ID: <CAK7LNAR3FW8wQe6Zsbj86LQpY4=ASC7Zec-HN4D70FNZcQk0_Q@mail.gmail.com> (raw)
In-Reply-To: <20210305024140.fv4i4ujreem2w7sw@treble>
On Fri, Mar 5, 2021 at 11:41 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> On Thu, Mar 04, 2021 at 11:12:42AM -0800, Linus Torvalds wrote:
> > On Thu, Mar 4, 2021 at 7:36 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > All the kernel-space objects are rebuilt
> > > when the compiler is upgraded.
> >
> > I very much NAK'ed that one. Why did that go in?
> >
> > Or maybe I NAK'ed another version of it (I think the one I NAK'ed was
> > from Josh), and didn't realize that there were multiple ones.
>
> This thread is making me dizzy,
Me too.
> Ok. So it sounds like the best/easiest option is the original patch in
> this thread: when building an external module with a GCC mismatch, just
> disable the GCC plugin, with a warning (or an error for randstruct).
Just for clarification,
I believe "the original patch" pointed to this one:
https://lore.kernel.org/lkml/efe6b039a544da8215d5e54aa7c4b6d1986fc2b0.1611607264.git.jpoimboe@redhat.com/
This is dead. Please do not come back to this.
See negative comments not only from me,
but also from Greg, Peter, Christoph.
> but I think the patch you NAK'ed from me
> was different. It just added an error on GCC mismatch with external
> modules:
>
> https://lkml.kernel.org/r/fff056a7c9e6050c2d60910f70b6d99602f3bec4.1611863075.git.jpoimboe@redhat.com
>
> though I think you were ok with downgrading it to a warning.
I think this was not NAKed.
At first, Linus NAKed it, but I think it was
just because of some misunderstanding.
I do not have an objection about checking
compiler version difference for external module
builds.
I was pointing out some mistakes in the Makefile implementation.
(I would say "not that way" even with your second trial).
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-03-05 16:05 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 20:42 [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules Josh Poimboeuf
2021-01-25 21:16 ` Masahiro Yamada
2021-01-25 21:27 ` Josh Poimboeuf
2021-01-25 21:44 ` Masahiro Yamada
2021-01-25 22:07 ` Josh Poimboeuf
2021-01-26 8:13 ` Greg KH
2021-01-26 12:44 ` Justin Forbes
2021-01-26 13:51 ` Greg KH
2021-01-26 14:51 ` Josh Poimboeuf
2021-01-26 15:00 ` Greg KH
2021-01-26 15:15 ` Peter Zijlstra
2021-01-26 15:46 ` Josh Poimboeuf
2021-01-26 16:05 ` Peter Zijlstra
2021-01-26 16:15 ` Justin Forbes
2021-01-26 16:19 ` Josh Poimboeuf
2021-01-26 17:06 ` Greg KH
2021-01-26 17:47 ` Justin Forbes
2021-01-26 16:22 ` David Laight
2021-01-27 18:03 ` Christoph Hellwig
2021-01-26 8:12 ` Greg KH
2021-01-25 22:03 ` Kees Cook
2021-01-25 22:19 ` Josh Poimboeuf
2021-01-26 17:56 ` Kees Cook
2021-01-26 18:43 ` Josh Poimboeuf
2021-01-26 22:59 ` Kees Cook
2021-01-26 23:32 ` Josh Poimboeuf
2021-01-26 1:53 ` Masahiro Yamada
2021-01-26 12:16 ` David Laight
2021-01-27 18:02 ` Christoph Hellwig
2021-01-27 18:38 ` Josh Poimboeuf
2021-01-27 18:43 ` Christoph Hellwig
2021-01-27 18:51 ` Josh Poimboeuf
2021-01-27 22:09 ` David Laight
2021-01-28 14:29 ` Christoph Hellwig
2021-01-28 15:45 ` Josh Poimboeuf
2021-03-02 23:26 ` Josh Poimboeuf
2021-03-03 18:49 ` Masahiro Yamada
2021-03-03 19:15 ` Josh Poimboeuf
2021-03-03 19:25 ` Linus Torvalds
2021-03-03 19:38 ` Josh Poimboeuf
2021-03-03 19:57 ` Linus Torvalds
2021-03-03 20:24 ` Josh Poimboeuf
2021-03-03 20:31 ` Josh Poimboeuf
2021-03-03 20:56 ` Linus Torvalds
2021-03-03 21:45 ` Josh Poimboeuf
2021-03-04 12:27 ` Masahiro Yamada
2021-03-04 15:08 ` Josh Poimboeuf
2021-03-04 15:35 ` Masahiro Yamada
2021-03-04 19:12 ` Linus Torvalds
2021-03-05 2:41 ` Josh Poimboeuf
2021-03-05 2:49 ` Linus Torvalds
2021-03-05 16:03 ` Masahiro Yamada [this message]
2021-03-05 19:18 ` Josh Poimboeuf
2021-03-08 9:39 ` David Laight
2021-03-05 15:31 ` Masahiro Yamada
2021-03-03 21:52 ` Kees Cook
2021-03-04 12:26 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAR3FW8wQe6Zsbj86LQpY4=ASC7Zec-HN4D70FNZcQk0_Q@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=fche@redhat.com \
--cc=jforbes@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=omosnace@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).