From: Masahiro Yamada <masahiroy@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendanhiggins@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Changbin Du <changbin.du@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] kconfig: unify cc-option and as-option
Date: Wed, 5 May 2021 06:05:42 +0900 [thread overview]
Message-ID: <CAK7LNAROdVMPQq4Qn_M=OWzJrfqNOc4fyMicNKdnCqu7G9rFgw@mail.gmail.com> (raw)
In-Reply-To: <58e4bd69c15fd0e0cf3de32e8ed53296d34c7e1e.camel@sipsolutions.net>
On Wed, May 5, 2021 at 5:52 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Wed, 2021-05-05 at 05:46 +0900, Masahiro Yamada wrote:
> >
> > - This commit touches scripts/Kconfig.include.
> > - External module builds (M= builds) never invoke Kconfig
> >
> > Putting these two together, your claim is really odd.
>
> Hmm.
>
> > If external module builds invoke Kconfig,
> > your kernel is already broken.
>
> Well, it's not about the kernel, that's just the normal upstream (or
> perhaps distribution) kernel.
>
> Anyway, you're right, it's much simpler. The problem isn't invoking M=
> or something like that, that happens much later and sent me on the
> completely wrong track.
>
> The problem is simply doing
>
> make kernelversion
>
> to determine the version of a tree that's not writable to the user, e.g.
>
> make -C /lib/modules/$(uname -r)/build/ kernelversion
>
> Which basically also means that it's harmless, since the version is of
> course not affected by cc-option.
It was fixed.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=805b2e1d427aab4bb27fa7c51ebb9db7547551b1
If you want to make it work without that commit,
make -C /lib/modules/$(uname -r)/build/ kernelversion M=/tmp
will work.
Pass a writable directory to M=.
M= build never touches the kernel source tree.
> johannes
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-05-04 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 14:43 [PATCH 1/2] kbuild: improve cc-option to clean up all temporary files Masahiro Yamada
2020-06-14 14:43 ` [PATCH 2/2] kconfig: unify cc-option and as-option Masahiro Yamada
2020-06-15 10:00 ` Will Deacon
2021-05-04 20:17 ` Johannes Berg
2021-05-04 20:46 ` Masahiro Yamada
2021-05-04 20:52 ` Johannes Berg
2021-05-04 21:05 ` Masahiro Yamada [this message]
2021-05-04 21:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAROdVMPQq4Qn_M=OWzJrfqNOc4fyMicNKdnCqu7G9rFgw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=changbin.du@intel.com \
--cc=johannes@sipsolutions.net \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=rdunlap@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).