From: Masahiro Yamada <masahiroy@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] trace: remove redundant dependency from IRQSOFF_TRACER
Date: Tue, 3 Aug 2021 14:14:53 +0900 [thread overview]
Message-ID: <CAK7LNARrkM7fAN8h792fFz8R3EEcLBJ74XXhP7ZKaATBy9KsrA@mail.gmail.com> (raw)
In-Reply-To: <20210802092952.3047bb99@oasis.local.home>
On Mon, Aug 2, 2021 at 10:29 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Sat, 31 Jul 2021 14:22:33 +0900
> Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> > IRQSOFF_TRACE is already guarded by a stronger condition,
> > TRACING_SUPPORT.
> >
> > 'depends on TRACE_IRQFLAGS_SUPPORT' is redundant.
>
> I'm fine with the other two patches, but this one concerns me. I'm not
> sure TRACING_SUPPORT really needs to depend on TRACE_IRQFLAGS_SUPPORT.
> When tracing was first introduced, the main use case was the irqsoff
> tracer. Today, with function graph tracing and events being introduced,
> it's one of the minor use cases of tracing support.
>
> I believe the only thing that requires the TRACE_IRQFLAGS_SUPPORT is
> the irqsoff tracer (and friends), so if anything, we should remove that
> dependency from TRACING_SUPPORT, not here.
OK.
The first two are more trivial, so please pick up
1/3 and 2/3, then drop this one.
BTW, I personally prefer HAVE_* to *_SUPPORT.
Maybe renaming as follows makes the code more consistent.
STACKTRACE_SUPPORT -> HAVE_STACKTRACE
TRACE_IRQFLAGS_SUPPORT -> HAVE_TRACE_IRQFLAGS
Documentation/kbuild/kconfig-language.rst says
HAVE_* style is the recommended way.
It is a common idiom to implement a feature/functionality that are
relevant for some architectures but not all.
The recommended way to do so is to use a config variable named HAVE_*
that is defined in a common Kconfig file and selected by the relevant
architectures.
An example is the generic IOMAP functionality.
We would in lib/Kconfig see::
# Generic IOMAP is used to ...
config HAVE_GENERIC_IOMAP
config GENERIC_IOMAP
depends on HAVE_GENERIC_IOMAP && FOO
> -- Steve
>
>
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > kernel/trace/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index 9d3f918b5867..b39e67db644e 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -265,7 +265,6 @@ config TRACE_PREEMPT_TOGGLE
> > config IRQSOFF_TRACER
> > bool "Interrupts-off Latency Tracer"
> > default n
> > - depends on TRACE_IRQFLAGS_SUPPORT
> > select TRACE_IRQFLAGS
> > select GENERIC_TRACER
> > select TRACER_MAX_TRACE
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2021-08-03 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 5:22 [PATCH 1/3] ftrace: simplify the Kconfig dependency of FTRACE Masahiro Yamada
2021-07-31 5:22 ` [PATCH 2/3] trace: refactor TRACE_IRQFLAGS_SUPPORT in Kconfig Masahiro Yamada
2021-07-31 6:50 ` Heiko Carstens
2021-07-31 23:12 ` Vineet Gupta
2021-08-02 2:56 ` Michael Ellerman
2021-08-02 15:55 ` Catalin Marinas
2021-08-02 18:03 ` Max Filippov
2021-08-25 3:49 ` Palmer Dabbelt
2021-07-31 5:22 ` [PATCH 3/3] trace: remove redundant dependency from IRQSOFF_TRACER Masahiro Yamada
2021-08-02 13:29 ` Steven Rostedt
2021-08-03 5:14 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARrkM7fAN8h792fFz8R3EEcLBJ74XXhP7ZKaATBy9KsrA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).