From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexei Starovoitov <ast@kernel.org>,
atish patra <atishp04@gmail.com>,
Daniel Colascione <dancol@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Karim Yaghmour <karim.yaghmour@opersys.com>,
Kees Cook <keescook@chromium.org>,
kernel-team@android.com,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-trace-devel@vger.kernel.org,
Manoj Rao <linux@manojrajarao.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
qais.yousef@arm.com, Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH v3 1/2] Provide in-kernel headers for making it easy to extend the kernel
Date: Sat, 2 Mar 2019 11:13:07 +0900 [thread overview]
Message-ID: <CAK7LNAShVt=zOPP1TUuBbR_H8kmc+zuLAyRXucjMMKrALkW_6A@mail.gmail.com> (raw)
In-Reply-To: <20190301171954.GA217990@google.com>
On Sat, Mar 2, 2019 at 3:03 AM Joel Fernandes <joel@joelfernandes.org> wrote:
>
> On Fri, Mar 01, 2019 at 03:25:05PM +0900, Masahiro Yamada wrote:
> [...]
> > > > I am guessing the user will run these commands
> > > > on the target system.
> > > > In other words, external modules are native-compiled.
> > > > So,
> > > >
> > > > target-arch: arm64
> > > > host-arch: arm64
> > > >
> > > >
> > > > Is this correct?
> > > >
> > > >
> > > > If I understood the assumed use-case correctly,
> > > > kheaders.tar.xw will contain host-programs compiled for x86,
> > > > which will not work on the target system.
> > > >
> > >
> > > You are right, the above commands in the commit message work only if the
> > > host/target are same arch due to scripts.
> > >
> > > However we can build with arm64 device connected to a host, like this (which
> > > I tested):
> > >
> > > adb shell modprobe kheaders; adb pull /proc/kheaders.tar.xz
> > > rm -rf $HOME/headers; mkdir -p $HOME/headers
> > > tar -xvf /proc/kheaders.tar.xz -C $HOME/headers >/dev/null
> > > cd my-kernel-module
> > > make -C $HOME/headers M=$(pwd) ARCH=arm64 CROSS_COMPILE=aarch64- modules
> > > adb push test.ko /data/; adb shell rmmod kheaders
> > >
> > > The other way we can make this work is using x86 usermode emulation inside a
> > > chroot on the Android device which will make the earlier commands work. One
> > > thing to note is that Android also runs on x86 hardware so the commands in
> > > the commit message will work even for x86 Android targets already.
> > >
> > > Also note that this the "module building" part is really only one of the
> > > usecases. eBPF is another which needs the headers - and the headers are vast
> > > majority of the archive. Headers take 3.1MB out of 3.6MB of the archive on
> > > arm64 builds.
> > >
> > > How do you want to proceed here, should I mention these points in the commit
> > > message?
> >
> >
> >
> > I do not request a re-spin just for a matter of commit log,
> > but this version produces an empty tarball.
> > So, you will have a chance to update the patch anyway.
> >
> > In the next version, it would be nice to note that
> > "external modules must be built on the same host arch
> > as built vmlinux".
>
> Ok, I respun it with 1 more minor nit for arm64 building. Please take a look.
I have not checked code-diff in v3 yet.
Anyway, I will add comments to v4
if I notice something.
> > Let me ask one more question.
> >
> > I guess this patch is motivated by
> > how difficult to convey kernel headers
> > from vendors to users.
> >
> > In that situation, how will the user find
> > the right compiler to use for building external modules?
> >
> >
> >
> >
> > Greg KH said:
> >
> > We don't ever support the system of loading a module built with anything
> > other than the _exact_ same compiler than the kernel was.
> >
> >
> > For the full context, see this:
> > https://lore.kernel.org/patchwork/patch/836247/#1031547
>
> IMO this issue is not related to this patch but is just an issue with
> building external modules in general.
I do not think it is an issue of the build system, at least.
As far as I understood Greg's comment, it is troublesome
without the assumption that vmlinux and modules are built
by the same compiler.
It is related to this patch since this patch assumes use-cases
where external modules are built in a completely different environment,
where a different compiler is probably installed.
> It is up to the user to use the right
> compiler, etc. I will let Greg comment more on that.
> thanks,
>
> - Joel
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-03-02 2:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 19:37 [PATCH v3 1/2] Provide in-kernel headers for making it easy to extend the kernel Joel Fernandes (Google)
2019-02-27 19:37 ` [PATCH v3 2/2] Add selftests for module build using in-kernel headers Joel Fernandes (Google)
2019-02-28 2:17 ` [PATCH v3 1/2] Provide in-kernel headers for making it easy to extend the kernel Masahiro Yamada
2019-02-28 14:43 ` Joel Fernandes
2019-02-28 23:27 ` Joel Fernandes
2019-03-01 6:25 ` Masahiro Yamada
2019-03-01 17:19 ` Joel Fernandes
2019-03-02 2:13 ` Masahiro Yamada [this message]
2019-03-02 2:39 ` Joel Fernandes
2019-03-04 5:40 ` Masahiro Yamada
2019-02-28 8:34 ` Masami Hiramatsu
2019-02-28 15:00 ` Joel Fernandes
2019-02-28 15:30 ` Greg KH
2019-02-28 15:37 ` Joel Fernandes
2019-02-28 15:45 ` Greg KH
2019-02-28 15:59 ` Joel Fernandes
2019-02-28 16:09 ` Steven Rostedt
2019-03-01 2:28 ` Masami Hiramatsu
2019-03-01 3:26 ` Joel Fernandes
2019-03-01 7:03 ` Masami Hiramatsu
2019-03-01 17:21 ` Joel Fernandes
2019-03-01 11:05 ` Qais Yousef
2019-02-28 13:53 ` Qais Yousef
2019-02-28 14:47 ` Joel Fernandes
2019-02-28 16:04 ` Dietmar Eggemann
2019-02-28 16:22 ` Qais Yousef
2019-02-28 16:48 ` Qais Yousef
2019-02-28 18:36 ` Dietmar Eggemann
2019-02-28 19:10 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAShVt=zOPP1TUuBbR_H8kmc+zuLAyRXucjMMKrALkW_6A@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=atishp04@gmail.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dancol@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=joel@joelfernandes.org \
--cc=karim.yaghmour@opersys.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux@manojrajarao.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).