From: Arnd Bergmann <arnd@arndb.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"sudeep.dutt@intel.com" <sudeep.dutt@intel.com>,
"ashutosh.dixit@intel.com" <ashutosh.dixit@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: sparse warnings in vop
Date: Sun, 2 Aug 2020 12:48:33 +0200 [thread overview]
Message-ID: <CAK8P3a0-gQEH3NpYUx=aFg6U8LagfYKuXqMMH4MvVS4SmaghOg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vfwhfrse47jRR9msFHA4ZqoVvE8RYHZNKxu-_ZiGyS9Sw@mail.gmail.com>
On Sun, Aug 2, 2020 at 9:25 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sunday, August 2, 2020, Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> Hi!
>> Building vop with make C=1 produces the following:
>>
>> CHECK drivers/misc/mic/vop/vop_main.c
>> drivers/misc/mic/vop/vop_main.c:551:58: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:551:58: expected void const volatile [noderef] __iomem *addr
>> drivers/misc/mic/vop/vop_main.c:551:58: got restricted __le64 *
>> drivers/misc/mic/vop/vop_main.c:560:49: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:560:49: expected struct mic_device_ctrl *dc
>> drivers/misc/mic/vop/vop_main.c:560:49: got struct mic_device_ctrl [noderef] __iomem *dc
>> drivers/misc/mic/vop/vop_main.c:579:49: warning: incorrect type in argument 1 (different address spaces)
>> drivers/misc/mic/vop/vop_main.c:579:49: expected struct mic_device_ctrl *dc
>> drivers/misc/mic/vop/vop_main.c:579:49: got struct mic_device_ctrl [noderef] __iomem *dc
>>
>> Would be nice to fix to silence the noise, but I'm not 100% sure
>> what the right thing to do here is. Tag struct members with __iomem or
>> cast with __force on use?
>
>
>
> Sounds right to me.
I don't think either of the above, adding __force is almost always wrong,
and __iomem never applies to struct members, only to pointers.
The first problem I see is with:
static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
The argument needs to be an __iomem pointer. In the structure, the
first member has type __le64, which gets mentioned in the warning.
We usually use __u64 instead (or don't use structures at all for __iomem
operations), but I don't think this would cause a warning if the argument
is fixed.
Then there is the question of why in the world you would have an MMIO
register contain a kernel pointer, but that is more a driver design question
than something that causes a warning.
Arnd
next prev parent reply other threads:[~2020-08-02 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 4:57 sparse warnings in vop Michael S. Tsirkin
[not found] ` <CAHp75Vfwhfrse47jRR9msFHA4ZqoVvE8RYHZNKxu-_ZiGyS9Sw@mail.gmail.com>
2020-08-02 10:48 ` Arnd Bergmann [this message]
2020-08-02 23:31 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0-gQEH3NpYUx=aFg6U8LagfYKuXqMMH4MvVS4SmaghOg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=andy.shevchenko@gmail.com \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).