From: Arnd Bergmann <arnd@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Viresh Kumar <vireshk@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Stratos Mailing List <stratos-dev@op-lists.linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Jason Wang <jasowang@redhat.com>,
"Stefano Garzarella --cc virtualization @ lists .
linux-foundation . org" <sgarzare@redhat.com>
Subject: Re: [Stratos-dev] [PATCH V3 1/3] gpio: Add virtio-gpio driver
Date: Fri, 11 Jun 2021 10:34:31 +0200 [thread overview]
Message-ID: <CAK8P3a2-bXfDcPymMct2aUXs2m+YgbKdmAatMMs9tnc+HjS_xQ@mail.gmail.com> (raw)
In-Reply-To: <01000179f9276678-ae2bb25f-4c0c-4176-b906-650c585b9753-000000@email.amazonses.com>
On Fri, Jun 11, 2021 at 5:39 AM Viresh Kumar via Stratos-dev
<stratos-dev@op-lists.linaro.org> wrote:
> On 10-06-21, 19:40, Jean-Philippe Brucker wrote:
> > On Thu, Jun 10, 2021 at 12:16:46PM +0000, Viresh Kumar via Stratos-dev wrote:
> > > +} __packed;
> >
> > No need for __packed, because the fields are naturally aligned (as
> > required by the virtio spec)
>
> Yeah, I know, but I tend to add that for structures which aren't very
> simple (like the request/response ones), just to avoid human errors
> and hours of debugging someone need to go through. __packed won't harm
> at least :)
Extraneous __packed annotations do cause real problems:
- On architectures without hardware unaligned accesses, the compiler is
forced to emit byte load/store instructions, which is slower and breaks
atomic updates to shared variables
- If a function takes a pointer of a packed struct member, and passes that
pointer to a function that expects a regular aligned pointer, you
get undefined
behavior. Newer compilers produce a warning if you do that (we currently
shut up that warning because there are many false positives in the kernel),
but you can also run into CPU exceptions or broken code even on CPUs
that do support unaligned accesses when the variable ends up being
actually unaligned (as you just told the compiler that it is allowed to do).
Arnd
next prev parent reply other threads:[~2021-06-11 8:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:09 [PATCH V3 0/3] gpio: Add virtio based driver Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Viresh Kumar
2021-06-10 13:22 ` Arnd Bergmann
2021-06-10 16:00 ` Enrico Weigelt, metux IT consult
[not found] ` <01000179f6a7715c-cd106846-7770-4088-bb7c-a696bfcbf83e-000000@email.amazonses.com>
2021-06-10 17:03 ` [Stratos-dev] " Jean-Philippe Brucker
2021-06-10 19:41 ` Arnd Bergmann
2021-06-14 10:21 ` Viresh Kumar
2021-06-14 12:31 ` Arnd Bergmann
2021-06-14 12:49 ` Vincent Guittot
[not found] ` <0100017a0a9264cc-57668c56-fdbf-412a-9f82-9bf95f5c653e-000000@email.amazonses.com>
2021-06-14 12:58 ` [Stratos-dev] " Arnd Bergmann
2021-06-14 13:24 ` Vincent Guittot
2021-06-14 20:54 ` Arnd Bergmann
2021-06-15 7:30 ` Vincent Guittot
2021-06-10 15:54 ` Enrico Weigelt, metux IT consult
2021-06-10 16:57 ` Viresh Kumar
2021-06-10 20:46 ` Linus Walleij
2021-06-11 3:56 ` Viresh Kumar
2021-06-11 7:42 ` Geert Uytterhoeven
2021-06-11 8:01 ` Viresh Kumar
2021-06-11 8:22 ` Geert Uytterhoeven
2021-06-15 11:15 ` Viresh Kumar
2021-06-15 11:37 ` Geert Uytterhoeven
2021-06-15 20:03 ` Linus Walleij
2021-06-16 1:45 ` Viresh Kumar
2021-06-14 8:07 ` Enrico Weigelt, metux IT consult
2021-06-14 8:12 ` Andy Shevchenko
2021-06-14 9:14 ` Viresh Kumar
2021-06-14 9:17 ` Enrico Weigelt, metux IT consult
2021-06-14 9:52 ` Viresh Kumar
2021-06-14 9:12 ` Viresh Kumar
2021-06-14 9:29 ` Enrico Weigelt, metux IT consult
2021-06-14 8:03 ` Enrico Weigelt, metux IT consult
2021-06-14 9:24 ` Viresh Kumar
2021-06-16 3:30 ` Bjorn Andersson
2021-06-16 15:52 ` Enrico Weigelt, metux IT consult
2021-06-18 9:13 ` Linus Walleij
2021-06-21 17:25 ` Bjorn Andersson
2021-06-10 12:16 ` [PATCH V3 2/3] gpio: virtio: Add IRQ support Viresh Kumar
2021-06-10 21:30 ` Linus Walleij
2021-06-14 7:08 ` Viresh Kumar
2021-06-10 12:16 ` [PATCH V3 3/3] MAINTAINERS: Add entry for Virtio-gpio Viresh Kumar
[not found] ` <01000179f5da7763-2ea817c6-e176-423a-952e-de02443f71e2-000000@email.amazonses.com>
2021-06-10 17:40 ` [PATCH V3 1/3] gpio: Add virtio-gpio driver Jean-Philippe Brucker
2021-06-11 3:39 ` Viresh Kumar
[not found] ` <01000179f9276678-ae2bb25f-4c0c-4176-b906-650c585b9753-000000@email.amazonses.com>
2021-06-11 8:34 ` Arnd Bergmann [this message]
2021-06-14 5:26 ` [Stratos-dev] " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2-bXfDcPymMct2aUXs2m+YgbKdmAatMMs9tnc+HjS_xQ@mail.gmail.com \
--to=arnd@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).