linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Olof Johansson <olof@lixom.net>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>, arm-soc <arm@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO"
Date: Thu, 20 Dec 2018 16:27:56 +0100	[thread overview]
Message-ID: <CAK8P3a3RLdRtY2ND0r4VQ5447V1WLYD6b9NcWjYvYR2AUCV1tg@mail.gmail.com> (raw)
In-Reply-To: <20181219101844.6362-1-horia.geanta@nxp.com>

On Wed, Dec 19, 2018 at 11:18 AM Horia Geantă <horia.geanta@nxp.com> wrote:
>
> This reverts commit d9678adbe733a770428a98651beaa2817d503ed3.
>
> Received below report from Stefan.
> Revert the commit until CAAM driver dependency cycles are fixed.
>
> this patch in next-20181214 breaks "make modules_install" for
> arm64/defconfig on my Ubuntu machine:
>
> DEPMOD  4.20.0-rc6-next-20181214
> depmod: ERROR: Found 6 modules in dependency cycles!
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
> depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>

I've applied the revert, but I think there is still a problem, since
anyone could manually enable those options and should not
see those cycles in the module dependencies.

Horia, can you have a look at what caused that and how to fix it?
It's probably a commit in the caam drivers. I have also created
a patch to address a problem with that driver but forgot
to send that out, it might fix this one as well, see my follow-up
patch "crypto: caam/qi2 - add a CRYPTO_DEV_FSL_CAAM
dependency".

       Arnd

  reply	other threads:[~2018-12-20 15:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09  0:54 [PATCH v3 0/9] Regenerate arm64 defconfig for current kernel Marc Gonzalez
2018-11-09  0:56 ` [PATCH v3 1/9] arm64: defconfig: Regenerate for v4.20 Marc Gonzalez
2018-12-13  2:09   ` Olof Johansson
2018-11-09  1:00 ` [PATCH v3 2/9] arm64: defconfig: Drop ARM_BIG_LITTLE_CPUFREQ Marc Gonzalez
2018-12-13  2:09   ` Olof Johansson
2018-11-09  1:01 ` [PATCH v3 3/9] arm64: defconfig: Drop NF_CONNTRACK_IPV{4,6} Marc Gonzalez
2018-12-13  2:09   ` Olof Johansson
2018-11-09  1:02 ` [PATCH v3 4/9] arm64: defconfig: Drop USB_ULPI_BUS and USB_CHIPIDEA_ULPI Marc Gonzalez
2018-12-13  2:14   ` Olof Johansson
2018-11-09  1:03 ` [PATCH v3 5/9] arm64: defconfig: Replace PINCTRL_MT7622 with PINCTRL_MTK_MOORE Marc Gonzalez
2018-11-09 13:03   ` Matthias Brugger
2018-11-09 19:59     ` Marc Gonzalez
2018-11-15 16:32       ` Matthias Brugger
2018-12-13  2:16   ` Olof Johansson
2018-11-09  1:03 ` [PATCH v3 6/9] arm64: defconfig: Drop redundant SND_SOC_ROCKCHIP_I2S Marc Gonzalez
2018-12-13  6:47   ` Olof Johansson
2018-11-09  1:07 ` [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Marc Gonzalez
2018-11-09  6:05   ` Horia Geanta
2018-12-13  6:48     ` Olof Johansson
2018-12-13  9:18       ` Ioana Ciocoi Radulescu
2018-12-15 21:44       ` Stefan Wahren
2018-12-17 15:33         ` Horia Geanta
2018-12-18 20:10           ` Stefan Wahren
2018-12-19 10:18             ` [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" Horia Geantă
2018-12-20 15:27               ` Arnd Bergmann [this message]
2018-12-20 20:43                 ` Horia Geanta
2018-11-09  1:08 ` [PATCH v3 8/9] arm64: defconfig: Change SCSI_UFS_HISI=m Marc Gonzalez
2018-12-13  6:48   ` Olof Johansson
2018-11-09  1:08 ` [PATCH v3 9/9] arm64: defconfig: Drop redundant sound codec options Marc Gonzalez
2018-12-13  6:50   ` Olof Johansson
2018-12-05 15:33 ` [PATCH v3 0/9] Regenerate arm64 defconfig for current kernel Marc Gonzalez
2018-12-11 15:41   ` Olof Johansson
2018-12-13  6:51     ` Olof Johansson
2018-12-14 15:44       ` Marc Gonzalez
2018-12-18 15:27         ` Arnd Bergmann
2018-12-18 18:31           ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3RLdRtY2ND0r4VQ5447V1WLYD6b9NcWjYvYR2AUCV1tg@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=horia.geanta@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=olof@lixom.net \
    --cc=sfr@canb.auug.org.au \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).