From: Arnd Bergmann <arnd@arndb.de>
To: Marco Elver <elver@google.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
christophe leroy <christophe.leroy@c-s.fr>,
Daniel Axtens <dja@axtens.net>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH -rcu] asm-generic, kcsan: Add KCSAN instrumentation for bitops
Date: Wed, 15 Jan 2020 20:27:39 +0100 [thread overview]
Message-ID: <CAK8P3a3b=SviUkQw7ZXZF85gS1JO8kzh2HOns5zXoEJGz-+JiQ@mail.gmail.com> (raw)
In-Reply-To: <20200115165749.145649-1-elver@google.com>
On Wed, Jan 15, 2020 at 5:58 PM Marco Elver <elver@google.com> wrote:
> * set_bit - Atomically set a bit in memory
> @@ -26,6 +27,7 @@
> static inline void set_bit(long nr, volatile unsigned long *addr)
> {
> kasan_check_write(addr + BIT_WORD(nr), sizeof(long));
> + kcsan_check_atomic_write(addr + BIT_WORD(nr), sizeof(long));
> arch_set_bit(nr, addr);
> }
It looks like you add a kcsan_check_atomic_write or kcsan_check_write directly
next to almost any instance of kasan_check_write().
Are there any cases where we actually just need one of the two but not the
other? If not, maybe it's better to rename the macro and have it do both things
as needed?
Arnd
next prev parent reply other threads:[~2020-01-15 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 16:57 [PATCH -rcu] asm-generic, kcsan: Add KCSAN instrumentation for bitops Marco Elver
2020-01-15 19:27 ` Arnd Bergmann [this message]
2020-01-15 19:51 ` Marco Elver
2020-01-15 19:54 ` Arnd Bergmann
2020-01-15 20:50 ` Marco Elver
2020-01-17 12:25 ` Arnd Bergmann
2020-01-17 13:14 ` Marco Elver
2020-01-20 14:23 ` Marco Elver
2020-01-20 14:40 ` Arnd Bergmann
2020-01-20 15:11 ` Marco Elver
2020-01-20 19:02 ` Arnd Bergmann
2020-01-21 16:12 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3b=SviUkQw7ZXZF85gS1JO8kzh2HOns5zXoEJGz-+JiQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=andreyknvl@google.com \
--cc=christophe.leroy@c-s.fr \
--cc=dja@axtens.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).