From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCF1C4338F for ; Wed, 4 Aug 2021 21:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E53460F43 for ; Wed, 4 Aug 2021 21:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233389AbhHDVKX (ORCPT ); Wed, 4 Aug 2021 17:10:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:40898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhHDVKW (ORCPT ); Wed, 4 Aug 2021 17:10:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 17ACA60F43 for ; Wed, 4 Aug 2021 21:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628111409; bh=AR7/8fSFLxcOU7ReweR1RJMUzQ2C6A8WBiBQgmubyxA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bstBTAnhv749RIOm/8A++1zEJoVPLjeLJya1QeLgs+5os8XLqTX8NVxd11Jh5ne0X 25RPg0sHRCshpt2JG73ht7Xyx5dhtErx1V8I9gCVolzqz237y6uQ98P1D4u3g0FnEH SnynInM+s3bEItadObYqiqLFG2NHBPRBkZeJYWhW+F5BV7++MeLDhNP+rF+X86XxpF aTbuCPg58JahZq3d68NRMmRAd9W2YnbjIVMfIoU5tbkiNR5tQSdrSe1ht84Lr9Z5cl 3geDZMkh8EWExQ4h3Kl04ZTQUyVWVA3XrMvZJNdyBdMaZiSkIusjDlYx8q+EiUfTyf 7lV0W67V/+P6g== Received: by mail-wm1-f45.google.com with SMTP id n11so1969504wmd.2 for ; Wed, 04 Aug 2021 14:10:09 -0700 (PDT) X-Gm-Message-State: AOAM532/wYGvR5hZ+vQXaI4SEVTXsFWt9rlKkM1tHc+rQT9NGglH+eCS ZjyynDceM8jCiDJUv3Rd5lgquF6FvL9GU9rYCvA= X-Google-Smtp-Source: ABdhPJxawV1DUFGq0xf4c1YWGB9f0ICNgrFaDVK4nvjPq8GUrxtQnE1yV12ZR4xxG8yzQp9mNDGQvEuc2xvVrRg4gF8= X-Received: by 2002:a7b:ce10:: with SMTP id m16mr11140796wmc.75.1628111407639; Wed, 04 Aug 2021 14:10:07 -0700 (PDT) MIME-Version: 1.0 References: <20210804141049.499767-1-kherbst@redhat.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 4 Aug 2021 23:09:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices To: Karol Herbst Cc: Linux Kernel Mailing List , Lyude Paul , Ben Skeggs , Randy Dunlap , Daniel Vetter , ML nouveau , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst wrote: > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann wrote: > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst wrote: > > > > > > > > playing around a little bit with this, I think the original "select > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > drivers selecting and others depending on it. We could of course convert > > > > everything over to depend, and break those cycling dependency issues with > > > > this. > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > too much. > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > keep working. > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > BACKLIGHT_CLASS_DEVICE might be disabled :( Are you sure? It should already be the case that any driver that selects FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' or 'select BACKLIGHT_CLASS_DEVICE'. If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends on', I don't see a problem with doing 'select FB_BACKLIGHT' from those. I have applied your patch to my randconfig tree and built a few dozen kernels, don't see any regressions so far, but will let it run over night. Arnd