From: Ohad Ben-Cohen <ohad@wizery.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Stuart Yoder <b08248@gmail.com>,
Scott Wood <scottwood@freescale.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Fri, 27 Jan 2012 09:08:44 +0200 [thread overview]
Message-ID: <CAK=WgbbZB0hGRr84JV4a7c0KvW7VbVzsnCx1PGg=wjoB0OSrYw@mail.gmail.com> (raw)
In-Reply-To: <1327603257-17028-3-git-send-email-joerg.roedel@amd.com>
Hi Joerg,
On Thu, Jan 26, 2012 at 8:40 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> Implement the attribute itself and add the code for the
> AMD IOMMU driver.
It's somewhat non-intuitive to have the generic attribute code bundled
with the AMD implementation in the same patch (took me some time to
find it here :).
Maybe split this to two patches ?
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index ef54718..3d0b0bf 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -345,10 +345,23 @@ EXPORT_SYMBOL_GPL(iommu_device_group);
> int iommu_domain_get_attr(struct iommu_domain *domain,
> enum iommu_attr attr, void *data)
> {
> - if (!domain->ops->domain_get_attr)
> - return -EINVAL;
> + struct iommu_domain_geometry *geometry;
> + int ret = 0;
> +
> + switch (attr) {
> + case DOMAIN_ATTR_GEOMETRY:
> + geometry = data;
> + *geometry = domain->geometry;
This is not type-safe and will surely bite someone some day.
Sure, we can't have type safety in a multi-purpose generic interface,
but I wonder whether this is the right interface for getting the
geometry ? I.e. why not have a dedicated API for this ?
Thanks,
Ohad.
next prev parent reply other threads:[~2012-01-27 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 18:40 [PATCH 0/6 v2] IOMMU: Make IOMMU-API ready for GART-like hardware Joerg Roedel
2012-01-26 18:40 ` [PATCH 1/6] iommu: Add domain-attribute handlers Joerg Roedel
2012-01-26 18:40 ` [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Joerg Roedel
2012-01-27 7:08 ` Ohad Ben-Cohen [this message]
2012-01-27 10:26 ` Joerg Roedel
2012-01-27 11:00 ` Ohad Ben-Cohen
2012-01-27 13:03 ` Joerg Roedel
2012-01-28 20:44 ` Ohad Ben-Cohen
2012-01-30 14:49 ` Joerg Roedel
2012-01-30 15:42 ` Ohad Ben-Cohen
2012-01-26 18:40 ` [PATCH 3/6] iommu/vt-d: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 4/6] iommu/omap: " Joerg Roedel
2012-01-26 18:40 ` [PATCH 5/6] iommu/msm: " Joerg Roedel
2012-01-27 0:07 ` David Brown
2012-01-26 18:40 ` [PATCH 6/6] iommu/tegra: " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=WgbbZB0hGRr84JV4a7c0KvW7VbVzsnCx1PGg=wjoB0OSrYw@mail.gmail.com' \
--to=ohad@wizery.com \
--cc=b08248@gmail.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).