From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Tom Rix <trix@redhat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Joe Perches <joe@perches.com>,
Nathan Chancellor <natechancellor@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] netfilter: conntrack: fix -Wformat
Date: Thu, 3 Dec 2020 15:40:12 +0100 [thread overview]
Message-ID: <CAKXUXMz4DffG-CW7RZu1X1irw7vpFyuvKyQA4d0C-v0Mq1r81w@mail.gmail.com> (raw)
In-Reply-To: <CANiq72=WZwcPcrnpwGzS=vAGBL6KuG49btKMbwOKTt=puC7qwA@mail.gmail.com>
On Thu, Dec 3, 2020 at 2:44 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Thu, Dec 3, 2020 at 8:26 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > It is not a competition between checkpatch and clang-format, but if it would be:
>
> Please note that clang-tidy is a different tool, it is designed to
> write lints based on the AST rather than formatting.
>
> > But jokes aside: Dwaipayan Ray, a mentee Joe and I are working with,
> > has already submitted a patch to checkpatch that identifies those
> > patterns and provides a fix:
> >
> > https://lore.kernel.org/lkml/20201128200046.78739-1-dwaipayanray1@gmail.com/
>
> That is very good! However, it does not hurt to have it repeated in
> clang-tidy too: it is a very good thing to have a full C parser behind
> when writing lints!
>
Completely agree. A regular expression is only a limited (but quite
powerful) heuristics to a full C parser :)
... and it did a good job in the case here.
Lukas
> Cheers,
> Miguel
next prev parent reply other threads:[~2020-12-03 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 7:55 [PATCH] netfilter: conntrack: fix -Wformat Nick Desaulniers
2020-11-07 10:32 ` Joe Perches
2020-11-08 7:34 ` Lukas Bulwahn
2020-11-08 10:10 ` Joe Perches
2020-11-10 22:00 ` Nick Desaulniers
2020-11-10 22:04 ` Joe Perches
2020-11-10 22:06 ` Nick Desaulniers
2020-12-02 22:34 ` Nick Desaulniers
2020-12-03 0:46 ` Tom Rix
2020-12-03 7:26 ` Lukas Bulwahn
2020-12-03 13:43 ` Miguel Ojeda
2020-12-03 14:40 ` Lukas Bulwahn [this message]
2020-12-03 14:39 ` Tom Rix
2020-12-03 16:45 ` Joe Perches
2020-12-13 19:21 ` Tom Rix
2020-12-13 23:25 ` Joe Perches
2020-12-13 23:29 ` Tom Rix
2020-11-07 17:52 ` Jakub Kicinski
2020-11-09 15:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXUXMz4DffG-CW7RZu1X1irw7vpFyuvKyQA4d0C-v0Mq1r81w@mail.gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).