From: Namjae Jeon <linkinjeon@gmail.com>
To: Rabin Vincent <rabin@rab.in>
Cc: fengguang.wu@intel.com, axboe@kernel.dk,
linux-kernel@vger.kernel.org, chanho0207@gmail.com
Subject: Re: [PATCHv2] backing-dev: fix wakeup timer races with bdi_unregister()
Date: Fri, 20 Jan 2012 08:46:56 +0900 [thread overview]
Message-ID: <CAKYAXd8poi6Rs7wyvZHre6qx-_i7eq0SBQAJNKNTYTLC5RQKjA@mail.gmail.com> (raw)
In-Reply-To: <1326991820-31393-1-git-send-email-rabin@rab.in>
> bdi_debug_unregister(bdi);
> - device_unregister(bdi->dev);
> +
> + spin_lock_bh(&bdi->wb_lock);
> bdi->dev = NULL;
> + spin_unlock_bh(&bdi->wb_lock);
Hi.
Would you explain me why you add spinlock in here ?
Thanks.
> +
> + device_unregister(dev);
> }
> }
> EXPORT_SYMBOL(bdi_unregister);
> --
> 1.7.7.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-01-19 23:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 8:49 [PATCH] mm/backing-dev.c: fix crash when USB/SCSI device is detached Chanho Min
2012-01-15 10:28 ` Rabin Vincent
2012-01-15 12:58 ` Wu Fengguang
2012-01-15 15:41 ` Rabin Vincent
2012-01-16 2:53 ` Wu Fengguang
2012-01-16 5:28 ` Chanho Min
2012-01-16 5:50 ` Wu Fengguang
2012-01-16 5:53 ` Wu Fengguang
2012-01-16 6:34 ` Chanho Min
2012-01-18 19:43 ` Rabin Vincent
2012-01-19 16:50 ` [PATCHv2] backing-dev: fix wakeup timer races with bdi_unregister() Rabin Vincent
2012-01-19 23:46 ` Namjae Jeon [this message]
2012-01-20 5:24 ` Rabin Vincent
2012-01-20 6:15 ` Namjae Jeon
2012-01-20 10:03 ` Rabin Vincent
2012-01-20 11:18 ` Namjae Jeon
2012-01-20 12:08 ` Rabin Vincent
2012-01-20 15:04 ` Namjae Jeon
2012-01-31 13:24 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd8poi6Rs7wyvZHre6qx-_i7eq0SBQAJNKNTYTLC5RQKjA@mail.gmail.com \
--to=linkinjeon@gmail.com \
--cc=axboe@kernel.dk \
--cc=chanho0207@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).