From: Vincent Guittot <vincent.guittot@linaro.org>
To: Josh Don <joshdon@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Paul Turner <pjt@google.com>, Oleg Rombakh <olegrom@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steve Sistare <steven.sistare@oracle.com>,
Tejun Heo <tj@kernel.org>, Rik van Riel <riel@surriel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] sched: account number of SCHED_IDLE entities on each cfs_rq
Date: Tue, 24 Aug 2021 09:57:47 +0200 [thread overview]
Message-ID: <CAKfTPtAN5tpux3rcvMR4PHdPL53=_bmX2pVtwjn7WmhsuxnZFA@mail.gmail.com> (raw)
In-Reply-To: <20210820010403.946838-3-joshdon@google.com>
On Fri, 20 Aug 2021 at 03:04, Josh Don <joshdon@google.com> wrote:
>
> Adds cfs_rq->idle_nr_running, which accounts the number of idle entities
> directly enqueued on the cfs_rq.
>
> Signed-off-by: Josh Don <joshdon@google.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/debug.c | 2 ++
> kernel/sched/fair.c | 25 ++++++++++++++++++++++++-
> kernel/sched/sched.h | 1 +
> 3 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 49716228efb4..33538579db9a 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -608,6 +608,8 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
> cfs_rq->nr_spread_over);
> SEQ_printf(m, " .%-30s: %d\n", "nr_running", cfs_rq->nr_running);
> SEQ_printf(m, " .%-30s: %d\n", "h_nr_running", cfs_rq->h_nr_running);
> + SEQ_printf(m, " .%-30s: %d\n", "idle_nr_running",
> + cfs_rq->idle_nr_running);
> SEQ_printf(m, " .%-30s: %d\n", "idle_h_nr_running",
> cfs_rq->idle_h_nr_running);
> SEQ_printf(m, " .%-30s: %ld\n", "load", cfs_rq->load.weight);
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 5aa3cfd15a2e..19a9244c140f 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -2995,6 +2995,8 @@ account_entity_enqueue(struct cfs_rq *cfs_rq, struct sched_entity *se)
> }
> #endif
> cfs_rq->nr_running++;
> + if (se_is_idle(se))
> + cfs_rq->idle_nr_running++;
> }
>
> static void
> @@ -3008,6 +3010,8 @@ account_entity_dequeue(struct cfs_rq *cfs_rq, struct sched_entity *se)
> }
> #endif
> cfs_rq->nr_running--;
> + if (se_is_idle(se))
> + cfs_rq->idle_nr_running--;
> }
>
> /*
> @@ -5573,6 +5577,17 @@ static int sched_idle_rq(struct rq *rq)
> rq->nr_running);
> }
>
> +/*
> + * Returns true if cfs_rq only has SCHED_IDLE entities enqueued. Note the use
> + * of idle_nr_running, which does not consider idle descendants of normal
> + * entities.
> + */
> +static bool sched_idle_cfs_rq(struct cfs_rq *cfs_rq)
> +{
> + return cfs_rq->nr_running &&
> + cfs_rq->nr_running == cfs_rq->idle_nr_running;
> +}
> +
> #ifdef CONFIG_SMP
> static int sched_idle_cpu(int cpu)
> {
> @@ -11556,7 +11571,7 @@ int sched_group_set_idle(struct task_group *tg, long idle)
> for_each_possible_cpu(i) {
> struct rq *rq = cpu_rq(i);
> struct sched_entity *se = tg->se[i];
> - struct cfs_rq *grp_cfs_rq = tg->cfs_rq[i];
> + struct cfs_rq *parent_cfs_rq, *grp_cfs_rq = tg->cfs_rq[i];
> bool was_idle = cfs_rq_is_idle(grp_cfs_rq);
> long idle_task_delta;
> struct rq_flags rf;
> @@ -11567,6 +11582,14 @@ int sched_group_set_idle(struct task_group *tg, long idle)
> if (WARN_ON_ONCE(was_idle == cfs_rq_is_idle(grp_cfs_rq)))
> goto next_cpu;
>
> + if (se->on_rq) {
> + parent_cfs_rq = cfs_rq_of(se);
> + if (cfs_rq_is_idle(grp_cfs_rq))
> + parent_cfs_rq->idle_nr_running++;
> + else
> + parent_cfs_rq->idle_nr_running--;
> + }
> +
> idle_task_delta = grp_cfs_rq->h_nr_running -
> grp_cfs_rq->idle_h_nr_running;
> if (!cfs_rq_is_idle(grp_cfs_rq))
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 8dfad8fb756c..6af039e433fb 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -530,6 +530,7 @@ struct cfs_rq {
> struct load_weight load;
> unsigned int nr_running;
> unsigned int h_nr_running; /* SCHED_{NORMAL,BATCH,IDLE} */
> + unsigned int idle_nr_running; /* SCHED_IDLE */
> unsigned int idle_h_nr_running; /* SCHED_IDLE */
>
> u64 exec_clock;
> --
> 2.33.0.rc2.250.ged5fa647cd-goog
>
next prev parent reply other threads:[~2021-08-24 7:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 1:03 [PATCH v3 0/4] SCHED_IDLE extensions Josh Don
2021-08-20 1:04 ` [PATCH v3 2/4] sched: account number of SCHED_IDLE entities on each cfs_rq Josh Don
2021-08-24 7:57 ` Vincent Guittot [this message]
2021-09-09 11:18 ` [tip: sched/core] sched: Account " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 3/4] sched: reduce sched slice for SCHED_IDLE entities Josh Don
2021-08-23 10:08 ` Vincent Guittot
2021-08-23 17:40 ` Josh Don
2021-08-24 7:56 ` Vincent Guittot
2021-08-24 10:24 ` Jiang Biao
2021-08-24 17:04 ` Josh Don
2021-08-25 2:43 ` Jiang Biao
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
2021-08-20 1:04 ` [PATCH v3 4/4] sched: adjust sleeper credit " Josh Don
2021-08-23 10:09 ` Vincent Guittot
2021-08-24 8:16 ` Jiang Biao
2021-08-24 17:12 ` Josh Don
2021-09-09 11:18 ` [tip: sched/core] " tip-bot2 for Josh Don
2021-10-05 14:12 ` tip-bot2 for Josh Don
[not found] ` <20210906124702.Q6G0oOWwFOmQSl_jmRms3XQgfz4ROzfE71r3SNgWSf0@z>
2021-09-06 12:47 ` [PATCH v3 1/4] sched: cgroup SCHED_IDLE support alexs
2021-08-20 8:39 ` Tao Zhou
2021-08-23 17:29 ` Josh Don
2021-08-23 22:45 ` Tao Zhou
2021-09-02 1:22 ` Daniel Jordan
2021-09-03 1:21 ` Josh Don
2021-09-08 20:38 ` Daniel Jordan
2021-09-08 18:36 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKfTPtAN5tpux3rcvMR4PHdPL53=_bmX2pVtwjn7WmhsuxnZFA@mail.gmail.com' \
--to=vincent.guittot@linaro.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=olegrom@google.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).